Export API routines for MSVC compiler#176
Merged
TyBalduf merged 1 commit intodftd4:mainfrom Oct 12, 2022
TyBalduf:msvc
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 60.12% 60.12%
=======================================
Files 44 44
Lines 3130 3130
Branches 1019 1019
=======================================
Hits 1882 1882
Misses 667 667
Partials 581 581
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* Exports must be explictly declared for the MSVC compiler. This commit adds DLLEXPORT attributes to the subroutines needed for the api and app to compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ty [email protected]
This still the same pull request as #168. Had to remake due to clunky choice of branching