Skip to content

build(cmake): enable language C to use MKL as BLAS#172

Merged
awvwgk merged 1 commit intodftd4:mainfrom
e-kwsm:FindBLAS-MKL
Oct 11, 2022
Merged

build(cmake): enable language C to use MKL as BLAS#172
awvwgk merged 1 commit intodftd4:mainfrom
e-kwsm:FindBLAS-MKL

Conversation

@e-kwsm
Copy link
Copy Markdown
Contributor

@e-kwsm e-kwsm commented Sep 19, 2022

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2022

Codecov Report

Merging #172 (e3072c8) into main (3e4ea97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   60.12%   60.12%           
=======================================
  Files          44       44           
  Lines        3130     3130           
  Branches     1019     1019           
=======================================
  Hits         1882     1882           
  Misses        667      667           
  Partials      581      581           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@awvwgk
Copy link
Copy Markdown
Member

awvwgk commented Sep 19, 2022

Can we conditionally enable this if we are searching for MKL (based on BLA_VENDOR)? The WITH_API option should do something similar already.

@e-kwsm
Copy link
Copy Markdown
Contributor Author

e-kwsm commented Sep 19, 2022

Thank you for your quick reply.

The WITH_API option should do something similar already.

Actually CMake does not seem to enable C at present (3e4ea97).

@awvwgk
Copy link
Copy Markdown
Member

awvwgk commented Sep 19, 2022

Actually CMake does not seem to enable C at present (3e4ea97).

Looks like I don't test the C API with CMake at the moment.

@awvwgk awvwgk merged commit 9ff1dc3 into dftd4:main Oct 11, 2022
@awvwgk awvwgk added the build Build system related issues (platform, compilers) label Oct 11, 2022
@e-kwsm e-kwsm deleted the FindBLAS-MKL branch October 11, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system related issues (platform, compilers)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants