pin fetched dependency versions in cmake build#146
Merged
awvwgk merged 1 commit intodftd4:mainfrom Feb 21, 2022
ricrogz:pin_fetched_deps_revs
Merged
pin fetched dependency versions in cmake build#146awvwgk merged 1 commit intodftd4:mainfrom ricrogz:pin_fetched_deps_revs
awvwgk merged 1 commit intodftd4:mainfrom
ricrogz:pin_fetched_deps_revs
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 42 42
Lines 3014 3014
Branches 1019 1019
=======================================
Hits 1779 1779
Misses 654 654
Partials 581 581 Continue to review full report at Codecov.
|
awvwgk
approved these changes
Feb 21, 2022
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Thanks for sharing.
The preferred way to build dftd4 is via meson rather than CMake, the latter is mainly available to support projects, which want to build dftd4 on-demand in CMake (like DFTB+). However, contributions to make the CMake build simpler/easier are always welcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when mctc-lib, mstore and multicharge are fetched, cmake always fetched the head of the repository.
This patch adds some code to pin the fetched dependencies to the same versions specified in dftd4/subprojects/*.wrap
This helps make automated builds more reproducible, although it would be desirable to centralize versions in a single central file, or at least set them up as global CMake variables.