Merged
Conversation
Member
awvwgk
commented
Nov 20, 2021
awvwgk
commented
- make error handling cleaner by using functools
- error out if both a method and parameters are provided to damping function constructor
awvwgk
force-pushed
the
python-refactor
branch
from
4f6c5ae to
89bbb17
Compare
|
This pull request introduces 1 alert when merging 89bbb17 into 982bb90 - view on LGTM.com new alerts:
|
- make error handling cleaner by using functools - error out if both a method and parameters are provided to damping function constructor - make examples in documentation - add method to return all damping parameters - support tomli library as TOML reader
awvwgk
force-pushed
the
python-refactor
branch
from
89bbb17 to
6493b5d
Compare
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 59.08% 59.04% -0.05%
==========================================
Files 42 42
Lines 2977 3008 +31
Branches 1016 1016
==========================================
+ Hits 1759 1776 +17
- Misses 640 654 +14
Partials 578 578
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.