Better check for exceptional floating point values#128
Merged
awvwgk merged 1 commit intodftd4:mainfrom Sep 28, 2021
Merged
Conversation
- also trap positive infinity when determining CN weights
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 59.16% 59.20% +0.04%
==========================================
Files 40 40
Lines 2946 2949 +3
Branches 995 995
==========================================
+ Hits 1743 1746 +3
Misses 642 642
Partials 561 561
Continue to review full report at Codecov.
|
|
Hi, I want to check back if there is any update on the problem discovered: I am still getting NaN in the OSZICAR compiled with the updated lines of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127