Magic parser - handling escapes and empty strings #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im magic parameters, an escaped backslash '\\' should be replaced by a single backslash, not by a two backslashes
in magics parameters, a quoted string should be able to be empty: "", so the check for current's length greater than 0 was removed
Contributor
|
Thanks for the PR. Could you add some unit tests to |
Test for - escaped backslash - quoted empty string
Contributor
Author
|
Done. |
Contributor
|
Thanks for the PR. Just to test the end user experience, I wrote a little dummy 
|
andrus
changed the title
andrus
added a commit
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed two bugs in magic parser in two separate commits: