fix unzippedArchive path when searching for psd1 file#25
Merged
dfinke merged 1 commit intodfinke:masterfrom Nov 27, 2022
Merged
fix unzippedArchive path when searching for psd1 file#25dfinke merged 1 commit intodfinke:masterfrom
dfinke merged 1 commit intodfinke:masterfrom
Conversation
Two changes:
* on non-unix platforms, fixed the psd1 file search
* join-path on line 87 was joining two full paths, which is not a
valid result.
* not sure how this could have been working previously
* allow the module to be in a repo subdirectory
* This would only be a breaking change if there could be module
dependancies in a parent directory above the module root, which I
don't think is possible. It also wouldn't support nested modules,
but I don't think those are supported by InstallMOduleFromGitHub anyways.
Contributor
|
Catching up from issue #28. I feel like this worked on windows when I opened my last PR, but having limited access to windows machines at the time, it’s entirely possible I’m misremembering. I was also running windows 10 on ps 5.1 and using a forked version of this repo to work with ps 5.1, so definitely not the best q/a environment. This change however appears to run just fine on my current windows 10 machine with ps7. |
|
I'm on PowerShell 7.3 / Win10 and the fix in this PR worked for me 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
valid result.
dependencies in a parent directory above the module root, which I
don't think is possible. It also wouldn't support nested modules,
but I don't think those are supported by InstallModuleFromGitHub anyways.