Skip to content

fix: require --ticket-creation-time in sns pay#159

Merged
lwshang merged 2 commits intomasterfrom
lwshang/pay_creation_time
Feb 14, 2023
Merged

fix: require --ticket-creation-time in sns pay#159
lwshang merged 2 commits intomasterfrom
lwshang/pay_creation_time

Conversation

@lwshang
Copy link
Copy Markdown
Contributor

@lwshang lwshang commented Feb 13, 2023 •
edited
Loading

Checklist:

  • I have made corresponding changes to the documentation in src/docs.

@lwshang lwshang marked this pull request as ready for review February 13, 2023 21:09
@lwshang lwshang assigned DanielThurau and unassigned DanielThurau Feb 13, 2023
@lwshang lwshang requested a review from DanielThurau February 13, 2023 21:10
DanielThurau
DanielThurau approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DanielThurau DanielThurau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwshang lwshang merged commit 81272c9 into master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamspofford-dfinity adamspofford-dfinity Awaiting requested review from adamspofford-dfinity

3 more reviewers

@DanielThurau DanielThurau DanielThurau approved these changes

@MarioDfinity MarioDfinity MarioDfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lwshang @DanielThurau @MarioDfinity