fix(station): bump ic-cdk to fix canister_status parsing#538
Conversation
|
Should we add a regression test testing the case of calling canister_status on the station for a canister with log visibility restricted to a set of principals? |
apps/wallet/src/components/external-canisters/CanisterIcSettingsForm.vue
Outdated
Show resolved
Hide resolved
I don't see any new test: did you push the test? |
|
@mraszyk https://github.com/dfinity/orbit/pull/538/files#diff-e825cffb84cec6b7f569564617db4e3bbcd0265eff65e9137e4308a3274e30d4R30-R49 Edit: But maybe you also meant a test for the external canister page backend itself, to see that the right panel is working properly. The lines above only cover the UI for modifications of LogVisibility, even though it's using the same source of data. |
What I meant is an integration test for the station's |
<img width="804" alt="Screenshot 2025-03-13 at 14 34 12" src="https://github.com/user-attachments/assets/6254efa9-37f5-4f45-b1e6-2f5c52a0fe6b" />


No description provided.