Skip to content

fix(station): bump ic-cdk to fix canister_status parsing#538

Merged
jedna merged 12 commits intomainfrom
jan/pen-454-cdk-bump
Mar 17, 2025
Merged

fix(station): bump ic-cdk to fix canister_status parsing#538
jedna merged 12 commits intomainfrom
jan/pen-454-cdk-bump

Conversation

@jedna
Copy link
Copy Markdown
Contributor

@jedna jedna commented Mar 11, 2025

No description provided.

@jedna jedna marked this pull request as ready for review March 12, 2025 08:34
@jedna jedna requested a review from a team as a code owner March 12, 2025 08:34
@mraszyk
Copy link
Copy Markdown
Contributor

mraszyk commented Mar 12, 2025

Should we add a regression test testing the case of calling canister_status on the station for a canister with log visibility restricted to a set of principals?

@jedna
Copy link
Copy Markdown
Contributor Author

jedna commented Mar 12, 2025

I updated the PR to display the disabled "Allowed viewers (unsupported)" option for canisters (disregard screenshot copy) with this value and the former 2-option select box for other canisters.

I also added the regression test to cover the behavior with these two canister_status response variants.

Another PR will come later to support allowed viewers in the UI fully.

Screenshot 2025-03-12 at 12 20 53 Screenshot 2025-03-12 at 12 22 47

@jedna jedna requested a review from keplervital March 12, 2025 12:50
@mraszyk
Copy link
Copy Markdown
Contributor

mraszyk commented Mar 13, 2025

I also added the regression test to cover the behavior with these two canister_status response variants.

I don't see any new test: did you push the test?

@jedna
Copy link
Copy Markdown
Contributor Author

jedna commented Mar 13, 2025

@mraszyk https://github.com/dfinity/orbit/pull/538/files#diff-e825cffb84cec6b7f569564617db4e3bbcd0265eff65e9137e4308a3274e30d4R30-R49

Edit: But maybe you also meant a test for the external canister page backend itself, to see that the right panel is working properly. The lines above only cover the UI for modifications of LogVisibility, even though it's using the same source of data.

@mraszyk
Copy link
Copy Markdown
Contributor

mraszyk commented Mar 13, 2025

@mraszyk https://github.com/dfinity/orbit/pull/538/files#diff-e825cffb84cec6b7f569564617db4e3bbcd0265eff65e9137e4308a3274e30d4R30-R49

Edit: But maybe you also meant a test for the external canister page backend itself, to see that the right panel is working properly. The lines above only cover the UI for modifications of LogVisibility, even though it's using the same source of data.

What I meant is an integration test for the station's canister_status endpoint. This was the first thing to fail in the reported issue.

@jedna jedna merged commit b06fd76 into main Mar 17, 2025
27 checks passed
@jedna jedna deleted the jan/pen-454-cdk-bump branch March 17, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants