Skip to content

chore(wallet): verify locale keys at dev/build#494

Merged
keplervital merged 7 commits intomainfrom
akos/verify-locale-keys
Feb 5, 2025
Merged

chore(wallet): verify locale keys at dev/build#494
keplervital merged 7 commits intomainfrom
akos/verify-locale-keys

Conversation

@olaszakos
Copy link
Copy Markdown
Contributor

Added a new build plugin that checks the secondary locales if they contain all keys the English locale does. Outputs a warning in dev, fails the build in prod. Also fixed the missing keys.

@olaszakos olaszakos requested a review from a team as a code owner February 4, 2025 11:54
Copy link
Copy Markdown
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keplervital keplervital enabled auto-merge (squash) February 4, 2025 16:00
@keplervital keplervital disabled auto-merge February 4, 2025 16:19
@keplervital keplervital merged commit cd302a3 into main Feb 5, 2025
@keplervital keplervital deleted the akos/verify-locale-keys branch February 5, 2025 11:49
jedna pushed a commit that referenced this pull request Feb 5, 2025
Added a new build plugin that checks the secondary locales if they
contain all keys the English locale does. Outputs a warning in dev,
fails the build in prod. Also fixed the missing keys.

---------

Co-authored-by: Kepler Vital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants