Repository navigation
build(deps): vortex-jni 0.90.0 - #621
Merged
Merged
Conversation
The interop suite passes against 0.90.0 except one case it cannot run: vortex-jni 0.90 keeps min/max statistics for nested columns (vortex-data/vortex#9775), and its writer's close() cannot convert a uuid's fixed_size_list(u8)[16] statistic to a Java object ("cannot return nested scalar write statistic", vortex-jni/src/writer.rs), so a vortex-jni writer with a uuid column fails to close. DictAllTypesInteropIntegrationTest skips its uuid case until upstream handles tuple scalars; the Java-writes direction still covers uuid. Supersedes #614. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vortex-jni 0.89.0 → 0.90.0, superseding #614.
The full integration suite (slow tests included) passes against 0.90.0 except one case it cannot run. vortex-jni 0.90 keeps min/max statistics for nested columns (vortex-data/vortex#9775), and its writer's
close()cannot convert a uuid'sfixed_size_list(u8)[16]statistic to a Java object:(
ScalarValue::Tupleis rejected invortex-jni/src/writer.rs.) So a vortex-jni writer with a uuid column fails to close, andDictAllTypesInteropIntegrationTestnow skips its uuid case (anassumeFalsenaming the cause) until upstream handles tuple scalars. The Java-writes / vortex-jni-reads direction still covers uuid.docs/compatibility.mdnames 0.90.0 as the tested reference; the edition catalog is unchanged (EditionCatalogParityIntegrationTestgreen).Tests
verify -pl integrationwithCI=true: 3,269 run, 0 failures, 4 skipped (the uuid case plus 3 already skipped).🤖 Generated with Claude Code