Skip to content

Commit 835a4b3

Browse files
dfa1claude
andcommitted
test: exclude diag tests from default run; disable CrashTest
BenchmarkTest and ZstdCompressionDiagTest have no assertions — they exist for manual inspection only. Tag both @tag("diag") and configure surefire excludedGroups so `mvnw test` stays fast and assertion-clean. CrashTest is an infinite loop (vortex-data/vortex#8075 reproducer); @disabled prevents accidental CI hang. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent 9280bce commit 835a4b3

5 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎CLAUDE.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
1111
# run a single test class
1212
./mvnw test -Dtest=CsvOhlcStoreTest
1313

14-
# run the benchmark (prints tables to stdout)
15-
./mvnw test -Dtest=BenchmarkTest
14+
# run the benchmark (prints tables to stdout) — excluded from default run
15+
./mvnw test -Dtest=BenchmarkTest -Dgroups=diag
1616

1717
# verify cross-format correctness
1818
./mvnw test -Dtest=CrossFormatConsistencyTest

‎pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
<version>3.5.2</version>
133133
<configuration>
134134
<argLine>--add-opens java.base/java.nio=ALL-UNNAMED --enable-native-access=ALL-UNNAMED --sun-misc-unsafe-memory-access=allow</argLine>
135+
<excludedGroups>diag</excludedGroups>
135136
</configuration>
136137
</plugin>
137138
</plugins>

‎src/test/java/io/github/dfa1/datastore/BenchmarkTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.github.dfa1.datastore;
22

3+
import org.junit.jupiter.api.Tag;
34
import org.junit.jupiter.api.Test;
45
import org.junit.jupiter.api.io.TempDir;
56

@@ -11,6 +12,7 @@
1112
import java.util.LongSummaryStatistics;
1213
import java.util.stream.LongStream;
1314

15+
@Tag("diag")
1416
class BenchmarkTest {
1517

1618
private static final int TRADING_DAYS_PER_YEAR = 252;

‎src/test/java/io/github/dfa1/datastore/CrashTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import dev.vortex.api.Partition;
44
import dev.vortex.api.Session;
5+
import org.junit.jupiter.api.Disabled;
56
import org.junit.jupiter.api.Test;
67
import org.junit.jupiter.api.io.TempDir;
78

@@ -15,6 +16,7 @@
1516
class CrashTest {
1617

1718
@Test
19+
@Disabled("infinite loop — manual reproducer for vortex-data/vortex#8075 only")
1820
void reproducer(@TempDir Path dir) throws IOException {
1921
VortexOhlcStore store = new VortexOhlcStore();
2022
int i = 0;

‎src/test/java/io/github/dfa1/datastore/ZstdCompressionDiagTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.github.luben.zstd.Zstd;
44
import com.github.luben.zstd.ZstdOutputStream;
5+
import org.junit.jupiter.api.Tag;
56
import org.junit.jupiter.api.Test;
67
import org.junit.jupiter.api.io.TempDir;
78

@@ -13,6 +14,7 @@
1314
import java.time.LocalDate;
1415
import java.util.List;
1516

17+
@Tag("diag")
1618
class ZstdCompressionDiagTest {
1719

1820
@Test

0 commit comments

Comments
 (0)