fix: Address CodeRabbit review - guard location and clipboard API

liz709 · liz709 · commit d22456ec7dfd · 2026-03-16T17:26:56.000+01:00
- Move typeof location check before Dexie.debug to prevent ReferenceError
  in non-browser environments (Node/SSR)
- Guard navigator.clipboard access with existence check
- Check execCommand('copy') return value - only show 'Copied!' on success
- Extract fallback copy logic into separate function
diff --git a/addons/dexie-cloud/src/authentication/authenticate.ts b/addons/dexie-cloud/src/authentication/authenticate.ts
@@ -251,7 +251,7 @@ async function userAuthenticate(
       const isOffline = typeof navigator !== 'undefined' && !navigator.onLine;
       if (isOffline) {
         message = `You seem to be offline. Please connect to the internet and try again.`;
-      } else if (Dexie.debug || (typeof location !== 'undefined' && (location.hostname === 'localhost' || location.hostname === '127.0.0.1'))) {
+      } else if (typeof location !== 'undefined' && (Dexie.debug || location.hostname === 'localhost' || location.hostname === '127.0.0.1')) {
         // The audience is most likely the developer. Suggest to whitelist the localhost origin:
         const whitelistCommand = `npx dexie-cloud whitelist ${location.origin}`;
         message = `Could not connect to server. Please verify that your origin '${location.origin}' is whitelisted using \`npx dexie-cloud whitelist\``;
diff --git a/addons/dexie-cloud/src/default-ui/LoginDialog.tsx b/addons/dexie-cloud/src/default-ui/LoginDialog.tsx
@@ -206,18 +206,13 @@ function CopyButton({ text }: { text: string }) {
   };
 
   const handleClick = () => {
-    navigator.clipboard.writeText(text).then(scheduleCopiedReset).catch(() => {
-      // Fallback for older browsers
-      const textarea = document.createElement('textarea');
-      textarea.value = text;
-      textarea.style.position = 'fixed';
-      textarea.style.opacity = '0';
-      document.body.appendChild(textarea);
-      textarea.select();
-      document.execCommand('copy');
-      document.body.removeChild(textarea);
-      scheduleCopiedReset();
-    });
+    if (typeof navigator !== 'undefined' && navigator.clipboard?.writeText) {
+      navigator.clipboard.writeText(text).then(scheduleCopiedReset).catch(() => {
+        fallbackCopy(text, scheduleCopiedReset);
+      });
+    } else {
+      fallbackCopy(text, scheduleCopiedReset);
+    }
   };
 
   return (
@@ -231,3 +226,15 @@ function CopyButton({ text }: { text: string }) {
     </button>
   );
 }
+
+function fallbackCopy(text: string, onSuccess: () => void) {
+  const textarea = document.createElement('textarea');
+  textarea.value = text;
+  textarea.style.position = 'fixed';
+  textarea.style.opacity = '0';
+  document.body.appendChild(textarea);
+  textarea.select();
+  const success = document.execCommand('copy');
+  document.body.removeChild(textarea);
+  if (success) onSuccess();
+}
