Add new RPC to list unconfirmed Omni transactions

dexX7 · dexX7 · commit 5bebb8178e11 · 2015-09-11T02:27:50.000+02:00
```
Returns a list of unconfirmed Omni transactions, pending in the memory pool.

An optional filter can be provided to only include transactions which involve the given address.

 #   "txid" : "hash",                  (string) the hex-encoded hash of the transaction
diff --git a/src/omnicore/rpc.cpp b/src/omnicore/rpc.cpp
@@ -1363,6 +1363,57 @@ Value omni_listtransactions(const Array& params, bool fHelp)
     return response;
 }
 
+Value omni_listpendingtransactions(const Array& params, bool fHelp)
+{
+    if (fHelp || params.size() > 1)
+        throw runtime_error(
+            "omni_listpendingtransactions ( \"address\" )\n"
+            "\nReturns a list of unconfirmed Omni transactions, pending in the memory pool.\n"
+            "\nAn optional filter can be provided to only include transactions which involve the given address.\n"
+            "\nNote: the validity of pending transactions is uncertain, and the state of the memory pool may "
+            "change at any moment. It is recommended to check transactions after confirmation, and pending "
+            "transactions should be considered as invalid.\n"
+            "\nArguments:\n"
+            "1. address              (string, optional) address filter (default: \"\" for no filter)\n"
+            "\nResult:\n"
+            "[                                 (array of JSON objects)\n"
+            "  {\n"
+            "    \"txid\" : \"hash\",                  (string) the hex-encoded hash of the transaction\n"
+            "    \"sendingaddress\" : \"address\",     (string) the Bitcoin address of the sender\n"
+            "    \"referenceaddress\" : \"address\",   (string) a Bitcoin address used as reference (if any)\n"
+            "    \"ismine\" : true|false,            (boolean) whether the transaction involes an address in the wallet\n"
+            "    \"fee\" : \"n.nnnnnnnn\",             (string) the transaction fee in bitcoins\n"
+            "    \"version\" : n,                    (number) the transaction version\n"
+            "    \"type_int\" : n,                   (number) the transaction type as number\n"
+            "    \"type\" : \"type\",                  (string) the transaction type as string\n"
+            "    [...]                             (mixed) other transaction type specific properties\n"
+            "  },\n"
+            "  ...\n"
+            "]\n"
+            "\nExamples:\n"
+            + HelpExampleCli("omni_listpendingtransactions", "")
+            + HelpExampleRpc("omni_listpendingtransactions", "")
+        );
+
+    std::string filterAddress;
+    if (params.size() > 0) {
+        filterAddress = ParseAddressOrEmpty(params[0]);
+    }
+
+    std::vector<uint256> vTxid;
+    mempool.queryHashes(vTxid);
+
+    Array result;
+    BOOST_FOREACH(const uint256& hash, vTxid) {
+        Object txObj;
+        if (populateRPCTransactionObject(hash, txObj, filterAddress) == 0) {
+            result.push_back(txObj);
+        }
+    }
+
+    return result;
+}
+
 Value omni_getinfo(const Array& params, bool fHelp)
 {
     if (fHelp || params.size() != 0)
diff --git a/src/rpcserver.cpp b/src/rpcserver.cpp
@@ -371,6 +371,7 @@ static const CRPCCommand vRPCCommands[] =
     { "omni layer (data retrieval)",         "omni_gettrade",                   &omni_gettrade,                   false,      true,       false },
     { "omni layer (data retrieval)",         "omni_getsto",                     &omni_getsto,                     false,      true,       false },
     { "omni layer (data retrieval)",         "omni_listblocktransactions",      &omni_listblocktransactions,      false,      true,       false },
+    { "omni layer (data retrieval)",         "omni_listpendingtransactions",    &omni_listpendingtransactions,    false,      true,       false },
     { "omni layer (data retrieval)",         "omni_getallbalancesforaddress",   &omni_getallbalancesforaddress,   false,      true,       false },
     { "omni layer (data retrieval)",         "omni_gettradehistoryforaddress",  &omni_gettradehistoryforaddress,  false,      true,       false },
     { "omni layer (data retrieval)",         "omni_gettradehistoryforpair",     &omni_gettradehistoryforpair,     false,      true,       false },
diff --git a/src/rpcserver.h b/src/rpcserver.h
@@ -242,6 +242,7 @@ extern json_spirit::Value omni_getorderbook(const json_spirit::Array& params, bo
 extern json_spirit::Value omni_gettrade(const json_spirit::Array& params, bool fHelp);
 extern json_spirit::Value omni_getsto(const json_spirit::Array& params, bool fHelp);
 extern json_spirit::Value omni_listblocktransactions(const json_spirit::Array& params, bool fHelp);
+extern json_spirit::Value omni_listpendingtransactions(const json_spirit::Array& params, bool fHelp);
 extern json_spirit::Value omni_getallbalancesforaddress(const json_spirit::Array& params, bool fHelp);
 extern json_spirit::Value omni_gettradehistoryforaddress(const json_spirit::Array& params, bool fHelp);
 extern json_spirit::Value omni_gettradehistoryforpair(const json_spirit::Array& params, bool fHelp);
