Reject "over-offers" after DEx feature activation

dexX7 · dexX7 · commit 51cb59ef62a9 · 2015-08-27T00:03:37.000+02:00
After this feature is enabled, it is no longer valid to create orders, which offer more than the seller has available, and the amounts are no longer adjusted based on the actual balance.

The second check can be left untouched, because the order adjustment is desired, as long as the feature is not enabled, and after the feature is enabled, it's body is no longer reached.
diff --git a/src/omnicore/dex.cpp b/src/omnicore/dex.cpp
@@ -10,6 +10,7 @@
 #include "omnicore/errors.h"
 #include "omnicore/log.h"
 #include "omnicore/omnicore.h"
+#include "omnicore/rules.h"
 
 #include "main.h"
 #include "tinyformat.h"
@@ -112,7 +113,7 @@ static int64_t calculateDesiredBTC(const int64_t amountOffered, const int64_t am
 /**
  * Determines the amount of bitcoins desired, in case it needs to be recalculated.
  *
- * TODO: use plain integers, don't expose it!
+ * TODO: don't expose it!
  * @return The amount of bitcoins desired
  */
 int64_t calculateDesiredBTC(const int64_t amountOffered, const int64_t amountDesired, const int64_t amountAvailable)
@@ -151,6 +152,21 @@ int DEx_offerCreate(const std::string& addressSeller, uint32_t propertyId, int64
 
     const int64_t balanceReallyAvailable = getMPbalance(addressSeller, propertyId, BALANCE);
 
+    /**
+     * After this feature is enabled, it is no longer valid to create orders, which offer more than
+     * the seller has available, and the amounts are no longer adjusted based on the actual balance.
+     */
+    if (IsFeatureActivated(FEATURE_DEXMATH, block)) {
+        if (amountOffered > balanceReallyAvailable) {
+            PrintToLog("%s: rejected: sender %s has insufficient balance of property %d [%s < %s]\n", __func__,
+                        addressSeller, propertyId, FormatDivisibleMP(balanceReallyAvailable), FormatDivisibleMP(amountOffered));
+            return (DEX_ERROR_SELLOFFER -25);
+        }
+    }
+
+    // -------------------------------------------------------------------------
+    // legacy::
+
     // if offering more than available -- put everything up on sale
     if (amountOffered > balanceReallyAvailable) {
         PrintToLog("%s: adjusting order: %s offers %s %s, but has only %s %s available\n", __func__,
@@ -165,6 +181,7 @@ int DEx_offerCreate(const std::string& addressSeller, uint32_t propertyId, int64
         PrintToLog("%s: adjusting order: updated amount for sale: %s %s, offered for: %s BTC\n", __func__,
                         FormatDivisibleMP(amountOffered), strMPProperty(propertyId), FormatDivisibleMP(amountDesired));
     }
+    // -------------------------------------------------------------------------
 
     if (amountOffered > 0) {
         assert(update_tally_map(addressSeller, propertyId, -amountOffered, BALANCE));
