UI: Override bitcoin transaction record for Omni transactions

zathras-crypto · zathras-crypto · commit 43d246660f41 · 2015-06-17T14:50:47.000+10:00
NOTE: The bitcoin transaction model for the UI breaks each transaction down into a series of records based primarily on outputs.
For Omni transactions this results in duplicate entries in Bitcoin transaction history, so we will override when decomposing the transaction.
diff --git a/src/qt/transactionrecord.cpp b/src/qt/transactionrecord.cpp
@@ -3,13 +3,17 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include "transactionrecord.h"
+#include "omnicore/omnicore.h"
+#include "omnicore/pending.h"
 
 #include "base58.h"
 #include "timedata.h"
 #include "wallet.h"
 
 #include <stdint.h>
 
+using namespace mastercore;
+
 /* Return positive answer if transaction should be shown in list.
  */
 bool TransactionRecord::showTransaction(const CWalletTx &wtx)
@@ -38,6 +42,34 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet *
     uint256 hash = wtx.GetHash();
     std::map<std::string, std::string> mapValue = wtx.mapValue;
 
+    // Omni override - since we use multiple outputs these show up as multiple transaction records
+    // and cause duplicate entries to be displayed in bitcoin history and overview recent
+    bool omniOverride = false;
+    PendingMap::iterator it = my_pending.find(hash);
+    if (it != my_pending.end()) omniOverride = true;
+    if (p_txlistdb->exists(hash)) omniOverride = true;
+    if (omniOverride) {
+        TransactionRecord sub(hash, nTime);
+        sub.idx = parts.size();
+        sub.address = "Omni transaction";
+        sub.involvesWatchAddress = false; // watch only support for Omni is an ongoing WIP
+        if (nNet > 0) { // inbound
+            sub.type = TransactionRecord::RecvWithAddress;
+            BOOST_FOREACH(const CTxOut& txout, wtx.vout) {
+                isminetype mine = wallet->IsMine(txout);
+                if (mine) {
+                    sub.credit += txout.nValue;
+                    if (mine == ISMINE_WATCH_ONLY) sub.involvesWatchAddress = true;
+                }
+            }
+        } else { // outbound
+            sub.type = TransactionRecord::SendToAddress;
+            sub.debit = nNet;
+        }
+        parts.append(sub);
+        return parts;
+    }
+
     if (nNet > 0 || wtx.IsCoinBase())
     {
         //
