Skip to content

Bump to SL-free ThisAssembly#660

Merged
kzu merged 1 commit intomainfrom
dev/bump-thisassembly
Oct 17, 2025
Merged

Bump to SL-free ThisAssembly#660
kzu merged 1 commit intomainfrom
dev/bump-thisassembly

Conversation

@kzu
Copy link
Copy Markdown
Member

@kzu kzu commented Oct 16, 2025

No description provided.

@kzu kzu added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Oct 16, 2025
@kzu kzu force-pushed the dev/bump-thisassembly branch from 4b767e2 to 7da08a2 Compare October 16, 2025 21:13
@kzu kzu enabled auto-merge (rebase) October 16, 2025 21:13
@kzu kzu mentioned this pull request Oct 16, 2025
Closed
@kzu kzu disabled auto-merge October 16, 2025 22:53
@kzu kzu force-pushed the dev/bump-thisassembly branch 2 times, most recently from d200177 to e2f2487 Compare October 17, 2025 03:07
@kzu
Copy link
Copy Markdown
Member Author

kzu commented Oct 17, 2025 •
edited
Loading

1 failed 304 passed 1 failed 1 skipped
305 passed 305 passed 1 skipped

🧪 Details on Microsoft Windows 10.0.26100
❌ NuGetizer.given_multitargeting_libraries.when_packing_on_build_then_succeeds(projectName: "uilibrary.csproj") 
Assert.Equal() Failure: Values differ
Expected: Success
Actual:   Failure
   at Builder.TargetResult.AssertSuccess(ITestOutputHelper output) in /_/src/NuGetizer.Tests/Builder.NuGetizer.cs:line 206
   at NuGetizer.given_multitargeting_libraries.when_packing_on_build_then_succeeds(String projectName) in /_/src/NuGetizer.Tests/given_multitargeting_libraries.cs:line 29
🧪 Details on Microsoft Windows 10.0.26100

from dotnet-retest v1.0.0 on .NET 9.0.10 with 💜 by @devlooped

@kzu kzu force-pushed the dev/bump-thisassembly branch from e2f2487 to 836cda8 Compare October 17, 2025 03:40
@kzu kzu enabled auto-merge (squash) October 17, 2025 03:40
@kzu kzu requested a review from Copilot October 17, 2025 03:59
Copilot AI reviewed Oct 17, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ThisAssembly package references from version 2.0.14 to version 2.1.2 across the codebase, removing SponsorLink dependencies as indicated by the "SL-free" designation in the PR title.

Key Changes:

  • Updated ThisAssembly.Project from 2.0.14 to 2.1.2
  • Updated ThisAssembly.Strings from 2.0.14 to 2.1.2
  • Updated ThisAssembly.AssemblyInfo from 2.0.14 to 2.1.2

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/dotnet-nugetize/dotnet-nugetize.csproj Updated ThisAssembly.Project and ThisAssembly.Strings package versions
src/NuGetizer.Tests/NuGetizer.Tests.csproj Updated ThisAssembly.Project and ThisAssembly.Strings package versions
src/NuGetizer.Tasks/NuGetizer.Tasks.csproj Updated ThisAssembly.Project and ThisAssembly.Strings package versions
src/CodeAnalysis/CodeAnalysis.csproj Updated ThisAssembly.AssemblyInfo and ThisAssembly.Strings package versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzu
Copy link
Copy Markdown
Member Author

kzu commented Oct 17, 2025

@copilot suggest a fix for this test error:

 D:\a\nugetizer\nugetizer\src\NuGetizer.Tests\bin\Release\net472\Scenarios\given_multitargeting_libraries\uilibrary.csproj
 Target: Build
 The workload 'net8.0-maccatalyst' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy.
 SupportedOSPlatformVersion 14.0 cannot be higher than TargetPlatformVersion 1.0.

@kzu kzu merged commit 60bccf8 into main Oct 17, 2025
6 of 7 checks passed
@kzu kzu deleted the dev/bump-thisassembly branch October 17, 2025 06:57
@devlooped devlooped locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kzu