Conversation
Since you can now include arbitrary files from any package by just adding the `PackageReference` metadata attribute to packed items, we just turn on the `GeneratePathProperty` metadata for all `PackageReference`s by default, since that only incurs minimal overhead in that it will create a new `PkgPACKAGE_ID` property on nuget restore, but that's about it. Fixes #35
When packing a package reference with PrivateAssets=all, you typically do so in order to run the resulting code from the target pack folder directly without having any extra dependencies that have to be resolved from elsewhere. For this typical use case, you'll want to pack actual "runnable" assemblies, not reference assemblies. Packages that pack reference assemblies (typically done for netstandard) resulted code that couldn't run because the packed assemblies contained no code. So we first look at related files that have a "/ref/" in the path, see if we can find the same file but under "/lib/" and if so, pack that instead. Fixes #36
Sometimes it may be useful to just pack the top-level dependency from a reference (i.e. you're getting the other deps by some other means, or the environment they run on doesn't require them, such as for Microsoft.Build.Framework, say). This allows just setting PackTransitive=false to stop the transitivity. Fixes #37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.