Conversation
Because of the way we were constructing the `_PrivateAssets` and `_ShouldPack` properties, we were ending with duplicates (i.e. `all;all`) if the package reference was both direct and indirectly included, since the previous item transform would basically concatenate all such values, breaking the condition in the subsequent item group. Rather than using an item transformation, we now instead just reference the item metadata directly, which will result in MSBuild iterating all items and assigning the property multiple times, once for each item. The last such item will determine the final property value. Therefore, we invert the Implicit references so they are processed first, so that an explicit `PackageReference.PrivateAssets` or `Pack` metadata trumps implicitly defined reference values. A new test ensures this is the case (it would fail without the fix) with the Shell.Interop VSSDK package. Fixes #28
First and most important: add unicode icons! Second: instead of hardcoding `preview` as the VS being searched, leverage the ability to select the first instance greater than or equal to 16.8 we find on the machine. This means we won't be force-installing a preview VS when 16.8 becomes the built-in version in hosted agents. Also, it means when 16.9 or future versions become stable too, we won't need to modify scripts again, since we'll automatically use a later version this way.
The default (powershell) for Windows doesn't seem to be working for adding envvar/path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.