Skip to content

Minor improvements and improved compatibility with SDK pack #137

Merged
kzu merged 4 commits intomainfrom
dev
Jul 23, 2021
Merged

Minor improvements and improved compatibility with SDK pack #137
kzu merged 4 commits intomainfrom
dev

Conversation

@kzu
Copy link
Copy Markdown
Member

@kzu kzu commented Jul 23, 2021

No description provided.

kzu added 4 commits July 22, 2021 23:22
Causes PackFolder=tool in nugetizer.

Fixes #131
SDK Pack always packs tools as framework-specific, so we
default to doing the same.

Fixes #132

tools
We used to perform no path normalization in the AssignPackagePath task, and this meant we could easily end with mixed paths, making it difficult to tell apart which are the same, and when comparing via code, having to take into account the possibility that there might be a mixture.

To simplify things, we now normalize all paths to use the / forward slash which is more compatible for cross-platform projects, is already supported universally in MSBuild as well as NuGet, and entirely avoids having to do \\ double slashes for escaping (or @ literals) in code.

Fixes #135
@kzu kzu enabled auto-merge (rebase) July 23, 2021 02:23
@kzu kzu merged commit 81f82f8 into main Jul 23, 2021
@kzu kzu deleted the dev branch July 23, 2021 02:29
@devlooped devlooped locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant