-
-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: devlooped/nugetizer
base: v0.5.0
head repository: devlooped/nugetizer
compare: v0.6.0
- 16 commits
- 52 files changed
- 1 contributor
Commits on Dec 2, 2020
-
Enable GeneratePathProperty by default
Since you can now include arbitrary files from any package by just adding the `PackageReference` metadata attribute to packed items, we just turn on the `GeneratePathProperty` metadata for all `PackageReference`s by default, since that only incurs minimal overhead in that it will create a new `PkgPACKAGE_ID` property on nuget restore, but that's about it. Fixes #35
Configuration menu - View commit details
-
Copy full SHA for e9ae6bf - Browse repository at this point
Copy the full SHA e9ae6bfView commit details
Commits on Dec 4, 2020
-
Convert ref to lib when packing transitive private dependencies
When packing a package reference with PrivateAssets=all, you typically do so in order to run the resulting code from the target pack folder directly without having any extra dependencies that have to be resolved from elsewhere. For this typical use case, you'll want to pack actual "runnable" assemblies, not reference assemblies. Packages that pack reference assemblies (typically done for netstandard) resulted code that couldn't run because the packed assemblies contained no code. So we first look at related files that have a "/ref/" in the path, see if we can find the same file but under "/lib/" and if so, pack that instead. Fixes #36
Configuration menu - View commit details
-
Copy full SHA for fff09d1 - Browse repository at this point
Copy the full SHA fff09d1View commit details -
Allow opting out of transitive private assets package reference packing
Sometimes it may be useful to just pack the top-level dependency from a reference (i.e. you're getting the other deps by some other means, or the environment they run on doesn't require them, such as for Microsoft.Build.Framework, say). This allows just setting PackTransitive=false to stop the transitivity. Fixes #37
Configuration menu - View commit details
-
Copy full SHA for 73ea2ae - Browse repository at this point
Copy the full SHA 73ea2aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a08968 - Browse repository at this point
Copy the full SHA 0a08968View commit details -
Import compatibility props for multi-targeting too
Because we were importing the compatibility props only from the non-multitargeting targets, the defaulting of PackOnBuild from GeneratePackageOnBuild was not being applied and that caused usage of that property to fail in multi-targeting projects. By bringing in the compat props from the shared targets (used in both single and multi targeting scenarios), we can properly default all values in all types of builds. Fixes #34
Configuration menu - View commit details
-
Copy full SHA for fe7db53 - Browse repository at this point
Copy the full SHA fe7db53View commit details -
Provide a default value for package description
SDK pack defaults the package description to the string Package Description if none is provided. Do the same in nugetizer so that installing the package doesn't start failing for packages (maybe internal?) where a description isn't provided. Fixes #40
Configuration menu - View commit details
-
Copy full SHA for 87aea86 - Browse repository at this point
Copy the full SHA 87aea86View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc1a52 - Browse repository at this point
Copy the full SHA cdc1a52View commit details -
When resolving P2P references for packaging, set target framework
When MSBuild project references are resolved, in multi-targeting P2P references, the `SetTargetFramework` metadata is populated with the nearest target framework supported by the referenced project (from the referencing project's point of view). For example, if a `netcore3.1` project references a `net5.0;netstandard2.1` one, when resolving the contents for the referenced project, the built-in targets will properly calculate (using the NuGet-provided GetReferenceNearestTargetFrameworkTask task) the target framework compatible with the referencing project. If we don't set the target framework, we end up inadvertently invoking targets on the project reference using the *calling* project target framework (in this case `netcoreapp3.1`), which is not supported by the referenced project and we end up with a missing MSBuild target import (since NuGet conditions the .props/.targets imports to the target framework), and it ends up manifesting itself as an error that the reference hasn't been nugetized, when in fact it's because we're invoking with the wrong TF. Fixes #27.
Configuration menu - View commit details
-
Copy full SHA for dae123f - Browse repository at this point
Copy the full SHA dae123fView commit details -
Add more common GetTargetPath to multi-targeting
We already add `GetTargetPathWithTargetPlatformMoniker` for multi-targeting, but `GetTargetPath` is probably more common, so we add it with the same pattern used in the built-in targets.
Configuration menu - View commit details
-
Copy full SHA for 0365f56 - Browse repository at this point
Copy the full SHA 0365f56View commit details
Commits on Dec 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 64a1e92 - Browse repository at this point
Copy the full SHA 64a1e92View commit details
Commits on Dec 8, 2020
-
When using PackageReference metadata infer Pack=true
This makes it behave just like PackagePath/PackFolder, and avoids having to explicitly add `Pack=true` after you specified `PackageReference`. For example: <None Include='lib\netstandard2.0\Newtonsoft.Json.dll' PackageReference='Newtonsoft.Json' /> Will now automatically be packed. The existing inference rules about target path/package path still apply, and in this case it will mean the file is packed to the same relative path as the referenced file in the source package reference. Fixes #44Configuration menu - View commit details
-
Copy full SHA for 7b1558c - Browse repository at this point
Copy the full SHA 7b1558cView commit details -
No need to set PackNone=true if PackageReference is set on a None item
Configuration menu - View commit details
-
Copy full SHA for 38db68d - Browse repository at this point
Copy the full SHA 38db68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cbeced - Browse repository at this point
Copy the full SHA 5cbecedView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7bdc5e - Browse repository at this point
Copy the full SHA c7bdc5eView commit details
Commits on Dec 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9dc2cb5 - Browse repository at this point
Copy the full SHA 9dc2cb5View commit details -
The microsoft/setup-msbuild@v1 action does not seem to work for bash CLI :(
Configuration menu - View commit details
-
Copy full SHA for 852d0b3 - Browse repository at this point
Copy the full SHA 852d0b3View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.5.0...v0.6.0