Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.12
Choose a base ref
...
head repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.0
Choose a head ref
  • 14 commits
  • 14 files changed
  • 1 contributor

Commits on Oct 29, 2020

  1. Merge pull request #25 from kzu/dev

    Make sure the output package cleanup happens before Pack
    kzu authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    4511f40 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Improve icon positioning in pages

    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c5f5d36 View commit details
    Browse the repository at this point in the history
  2. Use right image size

    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    179fe56 View commit details
    Browse the repository at this point in the history
  3. Fix package reference pack when referenced directly and indirectly

    Because of the way we were constructing the `_PrivateAssets` and `_ShouldPack` properties, we were ending with duplicates (i.e. `all;all`) if the package reference was both direct and indirectly included, since the previous item transform would basically concatenate all such values, breaking the condition in the subsequent item group.
    
    Rather than using an item transformation, we now instead just reference the item metadata directly, which will result in MSBuild iterating all items and assigning the property multiple times, once for each item. The last such item will determine the final property value. Therefore, we invert the Implicit references so they are processed first, so that an explicit `PackageReference.PrivateAssets` or `Pack` metadata trumps implicitly defined reference values.
    
    A new test ensures this is the case (it would fail without the fix) with the Shell.Interop VSSDK package.
    
    Fixes #28
    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d4badfa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1877f57 View commit details
    Browse the repository at this point in the history
  5. Update and future-proof build scripts

    First and most important: add unicode icons!
    Second: instead of hardcoding `preview` as the VS being searched, leverage the ability to select the first instance greater than or equal to 16.8 we find on the machine. This means we won't be force-installing a preview VS when 16.8 becomes the built-in version in hosted agents. Also, it means when 16.9 or future versions become stable too, we won't need to modify scripts again, since we'll automatically use a later version this way.
    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    eeb0324 View commit details
    Browse the repository at this point in the history
  6. When redirecting envvars/%path%, use bash

    The default (powershell) for Windows doesn't seem to be working for adding envvar/path
    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    da5d096 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. When inferring private dependencies, preserve item metadata

    The item metadata on a `PackageReference` may be useful to consumers that use `PrivateAssets` to automatically add implicit package references to transitive dependencies (i.e. to include all dependent assemblies as part of a build tasks assembli). The user-defined metadata may later be used to further tweak the inference (i.e. selectively removing some items from the resulting `PackageFile` items). For this scenario, it's useful to preserve the original metadata in the top-most `PackageReference` that triggers an implicit transitive dependency tree to be a candidate for inference.
    
    We also remove from the task the conditional checks on the package reference metadata since the targets already performed the same checks. This makes the task more flexible, should a user decide to invoke it explicitly as part of some custom inference they might want to perform (i.e. inferring content based on different metadata than `PrivateAssets=all`).
    kzu committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    21c09a6 View commit details
    Browse the repository at this point in the history
  2. Allow packing content from referenced packages

    Add support for a `PackageReference` metadata attribute on `PackageFile` so that content from other packages can be included more easily.
    
    Fixes #30.
    kzu committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    5d19ef4 View commit details
    Browse the repository at this point in the history
  3. Don't pack build-time tasks targets

    This file is only used for nugetizer tasks build itself.
    kzu committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    0b134a2 View commit details
    Browse the repository at this point in the history
  4. Fix issue with usage of PackOnBuild on multitargeting projects

    Due to the way we were setting up the BuildDependsOn when PackOnBuild == true, we were running Pack after build, regardless of whether the build was single or multi-targeting. This caused the Pack to run once for each TF, causing each build to overwrite the previous package and therefore leaving only the last TFM built as the package contents.
    
    This change switches to using Before/After targets and conditions instead with DependsOn for Build/Pack, as well as a mirror property to PackOnBuild, BuildOnPack to avoid building before pack (which the default behavior in SDK pack too).
    
    Fixes #32.
    kzu committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    03faffa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d95ef23 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #33 from kzu/dev

    Dev > Main
    kzu authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    75e514c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2ce9269 View commit details
    Browse the repository at this point in the history
Loading