-
-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: devlooped/nugetizer
base: v0.4.12
head repository: devlooped/nugetizer
compare: v0.5.0
- 14 commits
- 14 files changed
- 1 contributor
Commits on Oct 29, 2020
-
Merge pull request #25 from kzu/dev
Make sure the output package cleanup happens before Pack
Configuration menu - View commit details
-
Copy full SHA for 4511f40 - Browse repository at this point
Copy the full SHA 4511f40View commit details
Commits on Nov 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c5f5d36 - Browse repository at this point
Copy the full SHA c5f5d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 179fe56 - Browse repository at this point
Copy the full SHA 179fe56View commit details -
Fix package reference pack when referenced directly and indirectly
Because of the way we were constructing the `_PrivateAssets` and `_ShouldPack` properties, we were ending with duplicates (i.e. `all;all`) if the package reference was both direct and indirectly included, since the previous item transform would basically concatenate all such values, breaking the condition in the subsequent item group. Rather than using an item transformation, we now instead just reference the item metadata directly, which will result in MSBuild iterating all items and assigning the property multiple times, once for each item. The last such item will determine the final property value. Therefore, we invert the Implicit references so they are processed first, so that an explicit `PackageReference.PrivateAssets` or `Pack` metadata trumps implicitly defined reference values. A new test ensures this is the case (it would fail without the fix) with the Shell.Interop VSSDK package. Fixes #28
Configuration menu - View commit details
-
Copy full SHA for d4badfa - Browse repository at this point
Copy the full SHA d4badfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1877f57 - Browse repository at this point
Copy the full SHA 1877f57View commit details -
Update and future-proof build scripts
First and most important: add unicode icons! Second: instead of hardcoding `preview` as the VS being searched, leverage the ability to select the first instance greater than or equal to 16.8 we find on the machine. This means we won't be force-installing a preview VS when 16.8 becomes the built-in version in hosted agents. Also, it means when 16.9 or future versions become stable too, we won't need to modify scripts again, since we'll automatically use a later version this way.
Configuration menu - View commit details
-
Copy full SHA for eeb0324 - Browse repository at this point
Copy the full SHA eeb0324View commit details -
When redirecting envvars/%path%, use bash
The default (powershell) for Windows doesn't seem to be working for adding envvar/path
Configuration menu - View commit details
-
Copy full SHA for da5d096 - Browse repository at this point
Copy the full SHA da5d096View commit details
Commits on Nov 25, 2020
-
When inferring private dependencies, preserve item metadata
The item metadata on a `PackageReference` may be useful to consumers that use `PrivateAssets` to automatically add implicit package references to transitive dependencies (i.e. to include all dependent assemblies as part of a build tasks assembli). The user-defined metadata may later be used to further tweak the inference (i.e. selectively removing some items from the resulting `PackageFile` items). For this scenario, it's useful to preserve the original metadata in the top-most `PackageReference` that triggers an implicit transitive dependency tree to be a candidate for inference. We also remove from the task the conditional checks on the package reference metadata since the targets already performed the same checks. This makes the task more flexible, should a user decide to invoke it explicitly as part of some custom inference they might want to perform (i.e. inferring content based on different metadata than `PrivateAssets=all`).
Configuration menu - View commit details
-
Copy full SHA for 21c09a6 - Browse repository at this point
Copy the full SHA 21c09a6View commit details -
Allow packing content from referenced packages
Add support for a `PackageReference` metadata attribute on `PackageFile` so that content from other packages can be included more easily. Fixes #30.
Configuration menu - View commit details
-
Copy full SHA for 5d19ef4 - Browse repository at this point
Copy the full SHA 5d19ef4View commit details -
Don't pack build-time tasks targets
This file is only used for nugetizer tasks build itself.
Configuration menu - View commit details
-
Copy full SHA for 0b134a2 - Browse repository at this point
Copy the full SHA 0b134a2View commit details -
Fix issue with usage of PackOnBuild on multitargeting projects
Due to the way we were setting up the BuildDependsOn when PackOnBuild == true, we were running Pack after build, regardless of whether the build was single or multi-targeting. This caused the Pack to run once for each TF, causing each build to overwrite the previous package and therefore leaving only the last TFM built as the package contents. This change switches to using Before/After targets and conditions instead with DependsOn for Build/Pack, as well as a mirror property to PackOnBuild, BuildOnPack to avoid building before pack (which the default behavior in SDK pack too). Fixes #32.
Configuration menu - View commit details
-
Copy full SHA for 03faffa - Browse repository at this point
Copy the full SHA 03faffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d95ef23 - Browse repository at this point
Copy the full SHA d95ef23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75e514c - Browse repository at this point
Copy the full SHA 75e514cView commit details -
Only push to nuget.org when release is published
This is not triggered for draft releases, see https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#release.
Configuration menu - View commit details
-
Copy full SHA for 2ce9269 - Browse repository at this point
Copy the full SHA 2ce9269View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.4.12...v0.5.0