Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.10
Choose a base ref
...
head repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.12
Choose a head ref
  • 6 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 4, 2020

  1. Configuration menu
    Copy the full SHA
    49e4bdf View commit details
    Browse the repository at this point in the history
  2. Use right image size

    kzu authored Nov 4, 2020
    Configuration menu
    Copy the full SHA
    6be6012 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Fix package reference pack when referenced directly and indirectly

    Because of the way we were constructing the `_PrivateAssets` and `_ShouldPack` properties, we were ending with duplicates (i.e. `all;all`) if the package reference was both direct and indirectly included, since the previous item transform would basically concatenate all such values, breaking the condition in the subsequent item group.
    
    Rather than using an item transformation, we now instead just reference the item metadata directly, which will result in MSBuild iterating all items and assigning the property multiple times, once for each item. The last such item will determine the final property value. Therefore, we invert the Implicit references so they are processed first, so that an explicit `PackageReference.PrivateAssets` or `Pack` metadata trumps implicitly defined reference values.
    
    A new test ensures this is the case (it would fail without the fix) with the Shell.Interop VSSDK package.
    
    Fixes #28
    kzu committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    2754678 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6db00a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Update and future-proof build scripts

    First and most important: add unicode icons!
    Second: instead of hardcoding `preview` as the VS being searched, leverage the ability to select the first instance greater than or equal to 16.8 we find on the machine. This means we won't be force-installing a preview VS when 16.8 becomes the built-in version in hosted agents. Also, it means when 16.9 or future versions become stable too, we won't need to modify scripts again, since we'll automatically use a later version this way.
    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    36b33b9 View commit details
    Browse the repository at this point in the history
  2. When redirecting envvars/%path%, use bash

    The default (powershell) for Windows doesn't seem to be working for adding envvar/path
    kzu committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c2a4250 View commit details
    Browse the repository at this point in the history
Loading