Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0-rc
Choose a base ref
...
head repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 4 commits
  • 7 files changed
  • 1 contributor

Commits on Sep 30, 2020

  1. Add support for packing sources

    The behavior is similar to Content: if the packed items have CopyToOutputDirectory, they become part of the build output kind. Otherwise, they are treated like content with a default CodeLanguage that matches the project's default language source extension. This makes the most sense and would in most cases not require any futher metadata annotations.
    
    Tests ensure that the overriding of CodeLanguage, TargetFramework and other metadata still work as expected.
    kzu committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    27af2f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Make pack inference more flexible and avoid repeating code

    Adding support for EmbeddedResource packing (as supported by SDK pack) would have involved more copy/paste of exisitng MSBuild code, and that was becoming a red herring for maintainability.
    
    Taking inspiration from the awesome flexibility of the roslyn editor config generation from MSBuild (see https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L122-L154), we can now make it not only straightforward to add new item types for pack inference, but do so in a simple and maintainable way.
    
    The remaining built-in content type items will be added in separate commits to showcase how that will be done moving forward, based on the items at https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#including-content-in-a-package.
    kzu committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9ebaa40 View commit details
    Browse the repository at this point in the history
  2. Add remaining pack inference items from SDK pack

    The test showcases how the mechanism is itself extensible (which is what we basically did with the new built-in ones) and how the same rules can be applied to any custom item types.
    
    Corresponding PackXXX properties were added for each new item type, so they can also be defaulted to Pack=true (or false) automatically like the existing Content/Compile/None/EmbeddedResource.
    kzu committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4cb96d4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #6 from kzu/dev

    Dev > Main
    kzu authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a56ee06 View commit details
    Browse the repository at this point in the history
Loading