Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 473ad51
Choose a base ref
...
head repository: devlooped/nugetizer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b6d8405
Choose a head ref
  • 9 commits
  • 14 files changed
  • 3 contributors

Commits on Feb 23, 2023

  1. Configuration menu
    Copy the full SHA
    3aa66fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    66bc31d View commit details
    Browse the repository at this point in the history
  3. Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0

    Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
    - [Release notes](https://github.com/microsoft/vstest/releases)
    - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
    - [Commits](microsoft/vstest@v17.4.1...v17.5.0)
    
    ---
    updated-dependencies:
    - dependency-name: Microsoft.NET.Test.Sdk
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and kzu committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    e08ac1c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Allow extending the build with local-only targets

    These are always ignored and can therefore be tweaked without fear of inadvertently checking them in.
    kzu committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f821aee View commit details
    Browse the repository at this point in the history
  2. Render nuspec as a relative path to the nugetize output

    This makes it easier to take screenshots without revealing full local paths, while still preserving the click-ability of those file links if the terminal supports it.
    kzu committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    ed1106f View commit details
    Browse the repository at this point in the history
  3. Ensure transitive dependencies are properly resolved for inference

    .NET 7.0 SDK changed from:
    
    ```xml
        <ResolvePackageDependencies
          ProjectPath="$(MSBuildProjectFullPath)"
          ProjectAssetsFile="$(ProjectAssetsFile)"
          ProjectLanguage="$(Language)"
          EmitLegacyAssetsFileItems="$(EmitLegacyAssetsFileItems)"
          TargetFramework="$(TargetFramework)"
          ContinueOnError="ErrorAndContinue">
    
          <Output TaskParameter="PackageDefinitions" ItemName="PackageDefinitions" />
          <Output TaskParameter="PackageDependencies" ItemName="PackageDependencies" />
    
          <!-- These outputs only produced when EmitLegacyAssetsFileItems is true -->
          <Output TaskParameter="TargetDefinitions" ItemName="TargetDefinitions" />
          <Output TaskParameter="FileDefinitions" ItemName="FileDefinitions" />
          <Output TaskParameter="FileDependencies" ItemName="FileDependencies" />
        </ResolvePackageDependencies>
    ```
    
    to:
    
    ```xml
        <ResolvePackageDependencies
          ProjectPath="$(MSBuildProjectFullPath)"
          ProjectAssetsFile="$(ProjectAssetsFile)"
          ProjectLanguage="$(Language)"
          TargetFramework="$(TargetFramework)"
          ContinueOnError="ErrorAndContinue"
          Condition="'$(EmitLegacyAssetsFileItems)' == 'true'">
    
          <Output TaskParameter="PackageDefinitions" ItemName="PackageDefinitions" />
          <Output TaskParameter="PackageDependencies" ItemName="PackageDependencies" />
          <Output TaskParameter="TargetDefinitions" ItemName="TargetDefinitions" />
          <Output TaskParameter="FileDefinitions" ItemName="FileDefinitions" />
          <Output TaskParameter="FileDependencies" ItemName="FileDependencies" />
        </ResolvePackageDependencies>
    ```
    
    Since the SDK now conditions the execution of the resolve to the value of `EmitLegacyAssetsFileItems`, we need to explicitly set it.
    
    Since this was likely done for performance reasons, only turn on when package inference is active, since we don't use that anywhere else.
    kzu committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    2ca40f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Bump Microsoft.TestPlatform.ObjectModel from 17.4.1 to 17.5.0

    Bumps [Microsoft.TestPlatform.ObjectModel](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
    - [Release notes](https://github.com/microsoft/vstest/releases)
    - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
    - [Commits](microsoft/vstest@v17.4.1...v17.5.0)
    
    ---
    updated-dependencies:
    - dependency-name: Microsoft.TestPlatform.ObjectModel
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and kzu committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6cd5a24 View commit details
    Browse the repository at this point in the history
  2. Pack console apps using publish output by default

    We have an SDK-compatible mechanism for packing .NET tools: PackAsTool. This satisfies a very specific scenario for .NET tools, but doesn't work for regular CLI tools that don't need packing as standalone dotnet tools.
    
    For these CLI tools, packing the output of Publish makes much more sense, and results in way fewer customizations in package references.
    
    We introduce a new property, PackAsPublish, which is initialized to `true` whenever the project is publishable and a cross-platform executable (pending widening the definition upon feedback). In this case, we don't infer content from package dependencies and references with copy local and so on, but rather rely exclusively on Publish doing its work. We don't change the PackFolder treatment, so that property is orthogonal to PackAsPublish, although it's likely `tools` will be the most commonly used folder.
    
    The property's default `true` value is calculated dynamically in an initial target since we need to inspect `ProjectCapability` which is set by the SDK to include `CrossPlatformExecutable`. This is the more extensible approach, rather than checking the output type ourselves.
    kzu committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    38c07d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6d8405 View commit details
    Browse the repository at this point in the history
Loading