Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 17 commits
- 9 files changed
- 1 contributor
Commits on Oct 14, 2020
-
Add failing test re: VB.NET
ConvertnodesIt appears that VB.NET adds a pair of `Convert` nodes to expression trees for constrained generic type parameters. Those double conversions can end up "hiding" matchers thus wrapped from Moq's `MatcherFactory`.
-
Unwrap double (and triple, etc.) conversions
The existing code in `MatcherFactory` unwraps only one conversion node to get at matchers etc. This is not enough in the scenario documented in the previous commit's failing test, which causes two conversion nodes to be present. This bug fix assumes that any conversion nodes present are only there to satisfy the compiler's static type checks, but that they are irrele- vant (and can thus be removed) for any analysis that needs to be done to identify a suitable matcher. (It might be safer to not simply remove any conversion node blindly, but instead target this very specific VB.NET pattern and deal with it as a special case.)
-
-
Add failing test caused by regression in cb6b71a
Since that commit, inner mocks created by `Mock.Of<>()` no longer have their properties stubbed. `SetupAllProperties` is now only called for the root (outermost) mock. That's why nested properties can no longer be overridden simply by assigning to them.
-
Make
DefaultValue.Mockinherit property stubbingThe XML doc comment for `Mock<T>.SetupAllProperties()` states that: > If the mock's `DefaultValue` is set to `DefaultValue.Mock`, the > mocked default values will also get all properties setup recursively. But this does not actually happen! This commit changes the behavior of `DefaultValue.Mock` such that it does what it says on the tin. In theory, this could be a breaking change; let's see how many users have relied on behavior that contradicts the documentation. References: https://github.com/moq/moq4/blob/947c6a0aa1bbf265b5555ad0a84beb5bfc53b4e2/src/Moq/Mock.Generic.cs#L671-L674
-
-
-
-
-
-
More precise check for anonymous types
...since not all compiler-generated types are anonymous types.
-
-
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.14.6...v4.14.7