Conversation
The existing santizing wasn't enough. Fixes #155
|
FYI ThisAssembly.Resources already handles this, via |
|
It doesn't (at least fully). Which is why I'm sending this. With the file I added, I still get compilation errors. (I'm using the published 1.1.2) |
|
Interesting. Wonder what's different vs the other files already added (swagger-ui.json), etc. |
|
perhaps being top-level? The logic on that model sanitization should probably be unified (across the other generators too) and unit-tested... |
|
Ah, just realized it- only the path parts are being sanitized, not the name itself. Works with swagger-ui.json because there's also swagger-ui.css, so swagger-ui is part of the path, not the name. 🤦🏼♂️ |
|
Just downloaded 1.1.3, and it still misses cases. |
|
Yep, hopefully someone can end a PR if it's critical. I don't mind appending the As for reusing the name/identifier sanitization, it could just be a static class that all projects link/include and that's it. |
|
Including is easy - I just haven't read ThisAssembly.Strings well enough to figure out how to hook it in. I'll probably give you a PR for ThisAssembly.Resources later this week at least. |
The existing santizing wasn't enough.
Fixes #155