Skip to content

Fix logic for determining default text resources#148

Merged
kzu merged 1 commit intomainfrom
dev/extensions
Jan 1, 2023
Merged

Fix logic for determining default text resources#148
kzu merged 1 commit intomainfrom
dev/extensions

Conversation

@kzu
Copy link
Copy Markdown
Member

@kzu kzu commented Jan 1, 2023

We cannot use semicolons for properties passed to analyzers, we always lose all items except for the first one.

So we switch to a pipe instead. The existing logic was also not accurate since it should consider file extensions, not file name.

@kzu kzu added the bug Something isn't working label Jan 1, 2023
@kzu kzu enabled auto-merge (rebase) January 1, 2023 21:35
We cannot use semicolons for properties passed to analyzers, we always lose all items except for the first one.

So we switch to a pipe instead. The existing logic was also not accurate since it should consider file extensions, not file name.
@kzu kzu merged commit 2e37397 into main Jan 1, 2023
@kzu kzu deleted the dev/extensions branch January 1, 2023 21:48
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant