Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/ThisAssembly
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.2
Choose a base ref
...
head repository: devlooped/ThisAssembly
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.3
Choose a head ref
  • 12 commits
  • 16 files changed
  • 2 contributors

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    91afce4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca18b8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e97cfb View commit details
    Browse the repository at this point in the history
  4. Improve formatting of VSIX readme

    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    66f2cdf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f39f692 View commit details
    Browse the repository at this point in the history
  6. Simplify VSIX package manifest sample

    No need to showcase the xmlns attributes
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7a96c32 View commit details
    Browse the repository at this point in the history
  7. +Mᐁ includes

    devlooped-bot authored and kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c04f7e8 View commit details
    Browse the repository at this point in the history
  8. Allow constants to define custom root comment summary

    Since now most specific packages just extend and project @(Constant) items, they effectively are all "constants", and the comment on the root class used to be "Provides access project-defined constants.". This no longer is the case for the following:
    
    - Metadata: exposes project-defined AssemblyMetadata, not "constants"
    - AssemblyInfo: exposes [Assembly*] attributes
    - Git: build-time source repo information, not even project constants
    - Vsix: manifest values, again, not even project values.
    
    We should therefore allow a new metadata beside the `Root` attribute we added to allow custom roots: `RootComment`. Since each constant is emitted as a standalone file, we would have duplication, but we want to keep this approach for performance reasons.
    
    We default to the old comment if none is specified.
    Example of a custom constant with a custom root and its comment:
    
    ```xml
    <Constant Include="Foo.Bar" Value="Baz" Comment="A Bar value" Root="." RootComment="All the foos!" />
    ```
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9558384 View commit details
    Browse the repository at this point in the history
  9. Avoid non-Git constants conflict, update root comment

    As presently defined, if a custom constant in user's project had a naming conflict (i.e. `Root` or `Url`), the item metadata in the editorconfig/options would be mixed up, since it uses the item spec for that.
    
    By using the full area name, we avoid that, and switch instead to the custom root feature of using `Root=.` instead.
    
    We also take advantage of the new custom root summary comment to better reflect the nature of the provided constants.
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d604382 View commit details
    Browse the repository at this point in the history
  10. Provide custom Vsix class summary

    This reflects better where the values are coming from.
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a8824f9 View commit details
    Browse the repository at this point in the history
  11. Provide custom AssemblyInfo class summary

    To better reflect the source of the values
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    275e62f View commit details
    Browse the repository at this point in the history
  12. Provide custom Metadata class summary

    Note where the values come from in this package.
    kzu committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ed2f092 View commit details
    Browse the repository at this point in the history
Loading