Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/ThisAssembly
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.9
Choose a base ref
...
head repository: devlooped/ThisAssembly
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.10
Choose a head ref
  • 13 commits
  • 27 files changed
  • 3 contributors

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    bba6979 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Remove unused DebugThisAssembly properties

    These are no longer used since we use the built-in support for debugging roslyn components.
    kzu committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    88803b7 View commit details
    Browse the repository at this point in the history
  2. Make props/targets visible in the solution

    Since PackageFile is now hidden from solution by default by nugetizer.
    kzu committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    755c11d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Bump Scriban from 5.6.0 to 5.7.0

    Bumps [Scriban](https://github.com/scriban/scriban) from 5.6.0 to 5.7.0.
    - [Release notes](https://github.com/scriban/scriban/releases)
    - [Changelog](https://github.com/scriban/scriban/blob/master/changelog.md)
    - [Commits](scriban/scriban@5.6.0...5.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: Scriban
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    3d9e712 View commit details
    Browse the repository at this point in the history
  2. ⬆️ Bump files with dotnet-file sync

    # devlooped/oss
    
    - Allow extending build with local-only files devlooped/oss@6ae80a1
    - Use a better CI version number devlooped/oss@1ec6385
    - Don't run analyzers/codefixers in format devlooped/oss@543f7da
    - Only override VersionPrefix if it has no value devlooped/oss@28a27ba
    devlooped-bot authored and kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c62fc38 View commit details
    Browse the repository at this point in the history
  3. Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0

    Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0.
    - [Release notes](https://github.com/microsoft/vstest/releases)
    - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
    - [Commits](microsoft/vstest@v17.4.1...v17.5.0)
    
    ---
    updated-dependencies:
    - dependency-name: Microsoft.NET.Test.Sdk
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    660d10a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd55e9b View commit details
    Browse the repository at this point in the history
  5. Bump NuGetizer from 0.9.2 to 0.9.5

    dependabot[bot] authored and kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f4a20cc View commit details
    Browse the repository at this point in the history
  6. Remove old format local-only targets

    These can now be kept local by using a .props.user/.targets.user
    kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    9ccb3e3 View commit details
    Browse the repository at this point in the history
  7. Fix build issue when string resource has newlines

    The value when no Comment is provided in teh resource file is used to make up the code comment for the generated property. This breaks if the value has newlines in it.
    
    A workaround is for users to provide a shorter description in the resx, but we now also sanitize the value by replacing newlines with a whitespace.
    kzu committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    561c16e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. ThisAssembly should not propagate transitively by default

    Since we typically generate code that's intended for consumption within the project itself, we shouldn't cause other projects referencing the consuming project to also get ThisAssembly stuff.
    
    Fixes #210
    kzu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    936e3c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Bump to latest SL

    This includes single checks per IDE session and improved telemetry
    kzu committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1529e19 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Bump to latest SponsorLink and ensure private assets always

    Since analyzers are transitive by default (unless PrivateAssets=all in the PackageReference), we could have been inadvertently generating ThisAssembly classes via project-to-project (P2P) references and causing potential type name conflicts (if InternalsVisibleTo is also in use).
    
    This can happen if you add a package reference manually and forget to set PrivateAssets=all. But ThisAssembly is *always* intended to be private assets.
    
    After some testing, it turns out that even if we set the PrivateAssets=all via targets provided by the package itself, we can prevent this abnormal (but perhaps easy to encounter?) situation from happening at all.
    
    This is particularly necessary with the introduction of the SponsorLink checks, since those are analyzers too, and require compiler-visible properties to be surfaced.
    
    By forcing PrivateAssets, we make sure SponsorLink analyzer never runs on P2P projects and only on the directly referencing one.
    kzu committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d139b44 View commit details
    Browse the repository at this point in the history
Loading