Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 12 commits
- 16 files changed
- 2 contributors
Commits on Sep 30, 2024
-
-
-
-
-
Simplify VSIX package manifest sample
No need to showcase the xmlns attributes
-
-
Allow constants to define custom root comment summary
Since now most specific packages just extend and project @(Constant) items, they effectively are all "constants", and the comment on the root class used to be "Provides access project-defined constants.". This no longer is the case for the following: - Metadata: exposes project-defined AssemblyMetadata, not "constants" - AssemblyInfo: exposes [Assembly*] attributes - Git: build-time source repo information, not even project constants - Vsix: manifest values, again, not even project values. We should therefore allow a new metadata beside the `Root` attribute we added to allow custom roots: `RootComment`. Since each constant is emitted as a standalone file, we would have duplication, but we want to keep this approach for performance reasons. We default to the old comment if none is specified. Example of a custom constant with a custom root and its comment: ```xml <Constant Include="Foo.Bar" Value="Baz" Comment="A Bar value" Root="." RootComment="All the foos!" /> ```
-
Avoid non-Git constants conflict, update root comment
As presently defined, if a custom constant in user's project had a naming conflict (i.e. `Root` or `Url`), the item metadata in the editorconfig/options would be mixed up, since it uses the item spec for that. By using the full area name, we avoid that, and switch instead to the custom root feature of using `Root=.` instead. We also take advantage of the new custom root summary comment to better reflect the nature of the provided constants.
-
Provide custom Vsix class summary
This reflects better where the values are coming from.
-
Provide custom AssemblyInfo class summary
To better reflect the source of the values
-
Provide custom Metadata class summary
Note where the values come from in this package.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e55548b...ed2f092