Ensure only direct dependencies are exposed as analyzer props

kzu · kzu · commit 5038d77597e9 · 2024-07-10T10:36:45.000-03:00
See https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L566 We need to filter the restore graph by the ProjectUniqueName that matches the current project, since P2P references bring the transitive graph. Analyzers can now check for an analyzer option property named `build_property.My_Package` (for a package named `My.Package`).
diff --git a/samples/dotnet/SponsorLink/buildTransitive/Devlooped.Sponsors.targets b/samples/dotnet/SponsorLink/buildTransitive/Devlooped.Sponsors.targets
@@ -44,10 +44,15 @@
     <!-- Makes direct dependencies visible to the compiler, so that sponsoring checks can selectively skip indirectly referenced analyzer -->
     <!-- An analyzer can check for the presense of a global property named after the package id (which will contain the instaled version) -->
     <ItemGroup>
-      <CompilerVisibleProperty Include="$([MSBuild]::ValueOrDefault('%(_RestoreGraphEntry.Id)', '').Replace('.', '_'))" />
+      <DirectDependency Include="@(_RestoreGraphEntry -> HasMetadata('Id'))"
+                        Condition="'%(_RestoreGraphEntry.Type)' == 'Dependency' and
+                                   '%(_RestoreGraphEntry.ProjectUniqueName)' == '$(MSBuildProjectFullPath)'">
+        <Id>$([MSBuild]::ValueOrDefault('%(_RestoreGraphEntry.Id)', '').Replace('.', '_'))</Id>
+      </DirectDependency>
+      <CompilerVisibleProperty Include="@(DirectDependency -> '%(Id)')" />
     </ItemGroup>
-    <CreateProperty Value="%(_RestoreGraphEntry.VersionRange)" Condition="%(_RestoreGraphEntry.Type) == 'Dependency'" >
-      <Output TaskParameter="Value" PropertyName="$([MSBuild]::ValueOrDefault('%(_RestoreGraphEntry.Id)', '').Replace('.', '_'))"/>
+    <CreateProperty Condition="'@(DirectDependency)' != ''" Value="%(DirectDependency.VersionRange)">
+      <Output TaskParameter="Value" PropertyName="%(DirectDependency.Id)"/>
     </CreateProperty>
   </Target>
 
