Skip to content

Fix missing code from missing dependency#282

Merged
kzu merged 1 commit intomainfrom
dev/IsDirtyString
May 5, 2023
Merged

Fix missing code from missing dependency#282
kzu merged 1 commit intomainfrom
dev/IsDirtyString

Conversation

@kzu
Copy link
Copy Markdown
Member

@kzu kzu commented May 5, 2023

A missing feature in NuGetizer (see devlooped/nugetizer#388) caused our dependency on ThisAssembly.Constants to be lost now that it explicitly sets itself as PrivateAssets=all to prevent analyzer propagation to referenced projects.

This scenario (a package reference with PrivateAssets=all AND Pack=true) was not supported by NuGetizer.

We now do, so this bump is enough to fix the issue.

Fixes #281

A missing feature in NuGetizer (see devlooped/nugetizer#388) caused our dependency on ThisAssembly.Constants to be lost now that it explicitly sets itself as PrivateAssets=all to prevent analyzer propagation to referenced projects.

This scenario (a package reference with PrivateAssets=all AND Pack=true) was not supported by NuGetizer.

We now do, so this bump is enough to fix the issue.

Fixes #281
@kzu kzu added the bug label May 5, 2023
@kzu kzu enabled auto-merge (rebase) May 5, 2023 13:50
@kzu kzu merged commit 3a62220 into main May 5, 2023
@kzu kzu deleted the dev/IsDirtyString branch May 5, 2023 13:51
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The name 'IsDirtyString' does not exist in the current context

1 participant