Skip to content

update icon: nginx (original, original-wordmark, plain)#2291

Open
hasecilu wants to merge 6 commits intodevicons:developfrom
hasecilu:feat/nginx
Open

update icon: nginx (original, original-wordmark, plain)#2291
hasecilu wants to merge 6 commits intodevicons:developfrom
hasecilu:feat/nginx

Conversation

@hasecilu
Copy link
Copy Markdown

@hasecilu hasecilu commented Oct 28, 2024 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

[why]
The aspect ratio of the previous nginx logo made it very hard to read/identify on terminals, this new icon have a better aspect ratio making it identifiable.

[how]
Rename previous icon as wormark, add new original icon and its plain version to make it suitable for fonts, specifically Nerd Fonts.

This PR closes NONE

Notes

Ideally the new icon will be use for the next Nerd Fonts version.

nginx-original

@hasecilu
update icon: nginx (original, plain)
999c4a0 
[why]
The aspect ratio of the previous nginx logo made it very hard to
read/identify on terminals, this new icon have a better aspect ratio
making it identifiable.

[how]
Rename previous icon as wormark, add new original icon and its plain
version to make it suitable for fonts, specifically Nerd Fonts.
@hasecilu hasecilu mentioned this pull request Oct 28, 2024
Merged
4 tasks
Finii added a commit to ryanoasis/nerd-fonts that referenced this pull request Nov 13, 2024
@Finii
Devicons: Improve nginx icon
2bf267a 
[why]
Plain icon is missing but would be better than the wordmark icon.

[how]
Add plain icon, taken from their website.

[note]
Similar (but slightly different svg) to
devicons/devicon#2291

Suggested-by: hasecilu
Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit to ryanoasis/nerd-fonts that referenced this pull request Nov 13, 2024
@Finii
Devicons: Improve nginx icon
b25baf1 
[why]
Plain icon is missing but would be better than the wordmark icon.

[how]
Add plain icon, taken from their website.

[note]
Similar (but slightly different svg) to
devicons/devicon#2291

Suggested-by: hasecilu
Signed-off-by: Fini Jastrow <[email protected]>
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 17, 2024
@canaleal canaleal changed the title update icon: nginx (original, plain) update icon: nginx (original, original-wordmark, plain) Jun 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/nginx/nginx-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Snailedlt
Snailedlt requested changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part.
I changed the name of the wordmark to align with our naming conventions.

I also checked the official website to see if there were any official icons, but all of the ones I could find were either raster images, or included text in them. I did however see that the colors used on the official logos are slightly different from the ones you have.
There are two main colors being used on the nginx official website. These colors being: #009639 and #009828, of which the first is more prevalent... So I suggest we change the color to that.

Other than that, very good job!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jun 2, 2025
@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt requested changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plain version font has some artifacts. These can likely be fixed by starting from scratch and optimizing it again.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hasecilu @Snailedlt @canaleal