update icon: nodejs (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)#2011
Conversation
weh
requested review from
a team,
ConX,
Snailedlt,
canaleal and
lunatic-fox
and removed request for
a team
canaleal
added
the
feature:icon
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
The logos look good, but unfortunately they are outdated. The new logos look like this:
|
So it looks like the old nodejs-original.svg is also not allowed anymore if i understand the guideline correctly. |
I think that's it @weh. |
lunatic-fox
changed the title
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
@lunatic-fox Could you also take a look at these suggestions? :)
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
The code and the icons looks great!
Thank you @weh and @lunatic-fox for another awesome PR! 🚀
|
Since this PR was made by two people (therefore effectively reviewed by one of them) I'll merge this PR with only my approval :) |
|
awesome, thank you @Snailedlt |
|
@weh yeah this was a surprisingly difficult one! Don't hesitate to ask for help next time though :) |
|
sure, was still deciding, if i want to try it again ;) |
…rk, line, line-wordmark) (devicons#2011) * Replace plain with alias * Remove icons style attribute * Update icons * Commit suggestions --------- Co-authored-by: Josélio Júnior <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
|
As this turned up at Nerd Fonts, I must admit the
Excerpt from discussion at NF, pink lines and arrows added Edit: Improve image |
|
@Finii I agree those lines shouldn't be there. |
5 participants
Double check these details before you open a PR
Features
This PR closes NONE
Part of #2001
Notes