Skip to content

NotFoundError is not raised, but Python FileNotFoundError is raised #197

Closed

Description

@ion-elgreco

Noticed this while making an integration in dagster (dagster-io/dagster#27450), is that NotFoundError is not raised when you try to do obs.head(), you actually get the standard FileNotFoundError exception. Not sure if this was intended? But it threw me off for a second, since I imported the notFoundError from the execptions module : )

Activity

  1. kylebarron commented on Feb 3, 2025

    @kylebarron
    Member

    We can standardize on the obstore exception. Would you like to submit a PR?

  2. kylebarron commented on Jun 18, 2025

    @kylebarron
    Member

    I don't think it's currently possible to do multiple inheritance of exceptions in pyo3 PyO3/pyo3#4979

    At this point I think it's more likely that we remove our own NotFoundError and standardize on FileNotFoundError and just document that it's the primary error variant that doesn't subclass from BaseError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions