Skip to content

Doc: add shell highlighting to markdown#436

Merged
joshspicer merged 1 commit into
devcontainers:mainfrom
jarrodcolburn:shell-markdown
Mar 9, 2023
Merged

Doc: add shell highlighting to markdown#436
joshspicer merged 1 commit into
devcontainers:mainfrom
jarrodcolburn:shell-markdown

Conversation

@jarrodcolburn
Copy link
Copy Markdown
Contributor

@jarrodcolburn jarrodcolburn commented Mar 6, 2023

Just added a single word 'shell' to markdown to enable syntax highlighting. For comparison...

With ("shell" in markdown):

#!/bin/bash

set -e

# Import test library for `check` command
source dev-container-features-test-lib

check "Oryx version" oryx --version
check "Dotnet is not removed if it is not installed by the Oryx Feature" dotnet --version
...

Without:

#!/bin/bash

set -e

# Import test library for `check` command
source dev-container-features-test-lib

check "Oryx version" oryx --version
check "Dotnet is not removed if it is not installed by the Oryx Feature" dotnet --version
...

Note: If you're not noticing the difference, it's more apparent on dark themes

@jarrodcolburn jarrodcolburn requested a review from a team as a code owner March 6, 2023 21:12
joshspicer
joshspicer approved these changes Mar 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshspicer joshspicer enabled auto-merge (squash) March 9, 2023 18:44
@joshspicer joshspicer merged commit 946841a into devcontainers:main Mar 9, 2023
@jarrodcolburn jarrodcolburn deleted the shell-markdown branch March 9, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jarrodcolburn @joshspicer