This repository was archived by the owner on Jul 20, 2025. It is now read-only.
click events can work off existing mouse locations - fix a bug when no post data is sent #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o post data is sent
detro
added a commit
that referenced
this pull request
Sep 2, 2013
click events can work off existing mouse locations - fix a bug when no post data is sent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the Firefox and Chrome driver accept the /buttondown call with no post data. With Phantom I was getting this error message:
Phantom failed: [ERROR - 2013-08-29T18:21:21.612Z] RouterReqHand - _handle - Thrown => {
"message": "'undefined' is not an object (evaluating 'req.post.length')",
"line": 702,
"sourceId": 146917728,
"sourceURL": ":/ghostdriver/request_handlers/session_request_handler.js",
"stack": "TypeError: 'undefined' is not an object (evaluating 'req.post.length')\n at :/ghostdriver/request_handlers/session_request_handler.js:702\n at :/ghostdriver/request_handlers/session_request_handler.js:164\n at :/ghostdriver/request_handlers/request_handler.js:61\n at :/ghostdriver/request_handlers/router_request_handler.js:82",
"stackArray": [
{
"sourceURL": ":/ghostdriver/request_handlers/session_request_handler.js",
"line": 702
},
{
"sourceURL": ":/ghostdriver/request_handlers/session_request_handler.js",
"line": 164
},
{
"sourceURL": ":/ghostdriver/request_handlers/request_handler.js",
"line": 61
},
{
"sourceURL": ":/ghostdriver/request_handlers/router_request_handler.js",
"line": 82
}
]
}
** NOTE: I might be wrong, but it seems like the only post data that seems relevant to _postMouseClickCommand() is which mouse button to click, not the "Element ID or an X-Y Offset" as the comments in the code suggest.