feat: apply wise-mcp improvements — constrained inputs, recovery errors, next-action hints, GUI URLs, tool tags, typed config by ichoosetoaccept · Pull Request #198 · detailobsessed/codereviewbuddy

ichoosetoaccept · 2026-02-24T10:18:16Z

Description

Aligns the codereviewbuddy MCP server with wise-mcp skill best practices and Arcade's 52 agentic tool design patterns. Implements all 9 improvements from the audit plan.

Changes by improvement

#1 Constrained inputs — status parameters use Literal["resolved", "unresolved"], TriageItem.severity uses Literal["bug", "flagged", "warning", "info"], action uses Literal["fix", "reply", "create_issue"], limit on list_recent_unresolved uses Annotated[int, Field(ge=1, le=50)].

#2 Recovery-guided errors — new _recovery_error() helper in server.py classifies exceptions (auth, rate limit, not found, workspace, GraphQL, config) and returns actionable recovery hints. All 13 tool handlers updated.

#3 Next-action hints — next_steps: list[str] added to TriageResult, ResolveStaleResult, StackReviewStatusResult, CIDiagnosisResult. Populated contextually (e.g. "Fix the 2 bug/flagged items first").

#4 Async-wrap diagnose_ci — diagnose_ci call wrapped in call_sync_fn_in_threadpool() to avoid blocking the event loop.

#5 GUI URLs — comment_url added to TriageItem, url added to ReviewComment. GraphQL query updated to fetch comment URLs.

#6 Typed config response — ConfigInfo now includes an explanation field with a human-readable summary of active configuration highlights.

#7 Tool classification tags — all 13 tools tagged query, command, or discovery via @mcp.tool(tags={...}).

#8 Empty result messages — message field added to result models. Populated when results are empty (e.g. "No actionable threads — all threads have owner replies or are resolved.").

#9 Limit parameter bounds — list_recent_unresolved limit uses Annotated[int, Field(ge=1, le=50)] so the JSON Schema communicates bounds.

Also includes

README updates: 5 missing tools added to table, new Features sections (Triage & CI, Agent Experience), updated workflow, FastMCP v3 stable (removed RC disclaimer)
13 new tests for _recovery_error covering all classification branches
Existing test assertion updated for new error message format

Checklist

Tests added/updated
Documentation updated
poe check passes
Commit messages follow conventional commits

Related Issues

Closes #136 (PEP 758 false positive acknowledged in plan)

ichoosetoaccept · 2026-02-24T10:18:31Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps · 2026-02-24T10:20:49Z

Greptile Summary

Implements 9 wise-mcp improvements to enhance agent experience: constrained inputs via Literal types and Field bounds, recovery-guided errors with _recovery_error() classifier, next-action hints via next_steps fields, async-wrapped diagnose_ci, GUI URLs (comment_url, url), typed config with explanation, tool classification tags, empty result messages, and validated limit bounds. All 13 MCP tools updated to return structured guidance. README updated with 5 missing tools, new Agent Experience section, and removed FastMCP RC warnings. Includes 13 new tests for error recovery covering all classification branches.

Confidence Score: 5/5

Safe to merge — well-tested improvements with comprehensive test coverage and no breaking changes
All 9 improvements are backwards-compatible additions. New _recovery_error helper has 13 tests covering all branches. Type constraints use Literal correctly without breaking existing callers. Next-steps logic is additive (new fields with defaults). All changes follow established patterns in the codebase.
No files require special attention

Important Files Changed

Filename	Overview
src/codereviewbuddy/models.py	Added `next_steps`, `message`, `url`, `comment_url`, and `explanation` fields; constrained severity/action with Literal types
src/codereviewbuddy/server.py	Added `_recovery_error` helper for error classification; added tool tags; constrained status parameter with Literal; added bounds to limit parameter; async-wrapped diagnose_ci; added config explanation
src/codereviewbuddy/tools/comments.py	Added GraphQL url field fetch; populated next_steps/message in results; extracted _thread_to_triage_item and _build_triage_hints helpers; added comment_url to triage items
tests/test_server.py	Added 13 tests for `_recovery_error` covering all error classification branches (auth, rate limit, not found, workspace, GraphQL, config, generic)
README.md	Added 5 missing tools to table, new Agent Experience and Triage & CI sections, removed FastMCP RC warnings, updated workflow with next_steps guidance

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Tool Handler Called] --> B{Try Tool Operation}
    B -->|Success| C[Populate next_steps hints]
    C --> D[Return Result with guidance]
    B -->|Exception| E[_recovery_error classifier]
    E --> F{Error Type?}
    F -->|GhNotFoundError| G[Auth error: Install gh CLI]
    F -->|GhNotAuthenticatedError| H[Auth error: Run gh auth login]
    F -->|Rate limit/403| I[Wait 60s and retry]
    F -->|Not found/404| J[Check PR/repo exists]
    F -->|Workspace error| K[Set CRB_WORKSPACE or pass repo]
    F -->|GraphQL error| L[Retry once - transient issue]
    F -->|Config blocked| M[Call show_config to inspect]
    F -->|Generic| N[Generic fallback with hints]
    G --> O[Return error with recovery steps]
    H --> O
    I --> O
    J --> O
    K --> O
    L --> O
    M --> O
    N --> O

_{Last reviewed commit: edc542e}

greptile-apps

_{9 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-24T12:46:19Z

Additional Comments (1)

src/codereviewbuddy/tools/stack.py
incorrect exception syntax — multiple exception types must be wrapped in parentheses

        except (ValueError, AttributeError):

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/codereviewbuddy/tools/stack.py
Line: 562

Comment:
incorrect exception syntax — multiple exception types must be wrapped in parentheses

```suggestion
        except (ValueError, AttributeError):
```

How can I resolve this? If you propose a fix, please make it concise.

ichoosetoaccept · 2026-02-24T13:42:56Z

The except ValueError, AttributeError: syntax on line 562 is not a bug — it's valid Python 3.14+ syntax introduced by PEP 758 (Allow except and except* expressions without parentheses). This project requires Python 3.14+ (see badge and pyproject.toml).

The confidence score should not be impacted by this. All other observations in the review are accurate.

ichoosetoaccept · 2026-02-24T16:39:08Z

Merge activity

Feb 24, 4:39 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Feb 24, 4:40 PM UTC: Graphite rebased this pull request as part of a merge.
Feb 24, 4:41 PM UTC: @ichoosetoaccept merged this pull request with Graphite.

… stable, agent experience features

ichoosetoaccept mentioned this pull request Feb 24, 2026

test: improve ci.py coverage to fix CI fail-under threshold #193

Merged

3 tasks

ichoosetoaccept force-pushed the wise-mcp-improvements branch from ed82ff0 to 479d231 Compare February 24, 2026 12:43

greptile-apps bot reviewed Feb 24, 2026

View reviewed changes

ichoosetoaccept changed the base branch from 02-19-test-improve-ci-coverage to graphite-base/198 February 24, 2026 16:39

ichoosetoaccept changed the base branch from graphite-base/198 to main February 24, 2026 16:39

docs: update README for wise-mcp improvements — new tools, FastMCP v3…

edc542e

… stable, agent experience features

ichoosetoaccept force-pushed the wise-mcp-improvements branch from 479d231 to edc542e Compare February 24, 2026 16:40

ichoosetoaccept merged commit 6d9ef26 into main Feb 24, 2026
7 checks passed

ichoosetoaccept deleted the wise-mcp-improvements branch February 24, 2026 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: apply wise-mcp improvements — constrained inputs, recovery errors, next-action hints, GUI URLs, tool tags, typed config#198

feat: apply wise-mcp improvements — constrained inputs, recovery errors, next-action hints, GUI URLs, tool tags, typed config#198
ichoosetoaccept merged 1 commit intomainfrom
wise-mcp-improvements

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading

Uh oh!

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot commented Feb 24, 2026

Uh oh!

ichoosetoaccept commented Feb 24, 2026

Uh oh!

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ichoosetoaccept commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes by improvement

Also includes

Checklist

Related Issues

Uh oh!

ichoosetoaccept commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 24, 2026

Uh oh!

ichoosetoaccept commented Feb 24, 2026

Uh oh!

ichoosetoaccept commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading

greptile-apps bot commented Feb 24, 2026 •

edited

Loading

ichoosetoaccept commented Feb 24, 2026 •

edited

Loading