test: improve ci.py coverage to fix CI fail-under threshold#193
Merged
ichoosetoaccept merged 1 commit intomainfrom Feb 24, 2026
Merged
test: improve ci.py coverage to fix CI fail-under threshold#193ichoosetoaccept merged 1 commit intomainfrom
ichoosetoaccept merged 1 commit intomainfrom
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryAdded comprehensive test coverage for
All tests follow existing patterns, use appropriate mocks, and verify the expected behavior without introducing logical issues. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: aca4375 |
4 tasks
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds 70 lines of new test coverage for
tools/ci.pyto bring the CI module above the fail-under threshold. Covers error paths, edge cases in log parsing, and therun_idvspr_numberdetection branches.Changes
tests/test_ci.py— new test cases for CI diagnosis edge cases (empty logs, missing steps, malformed output, run ID lookup)Checklist
poe checkpassesRelated Issues
Fixes CI coverage regression from #192 (
diagnose_citool addition).