• fix: validate repo format before splitting in all tool functions #184 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Greptile Summary

Extracts a new parse_repo function in gh.py that validates "owner/repo" format (including empty-component checks) and replaces 7 raw repo.split("/", 1) calls across the tool modules with gh.parse_repo(repo). This ensures consistent, early validation with clear error messages instead of silent malformed API paths.

• New parse_repo() centralizes repo string validation with GhError on invalid input
• All tool functions in comments.py, issues.py, and stack.py now use the shared validator
• Test suite covers valid input, missing slash, empty string, empty owner, and empty repo cases
• Note: get_repo_info() in gh.py:314 still uses a raw split("/", 1) — acceptable since its input comes from the gh CLI, but could be updated for consistency in a follow-up

Confidence Score: 4/5

• This PR is safe to merge — it adds input validation without changing any existing behavior for valid inputs.
• The changes are straightforward, well-tested, and purely additive in terms of validation. One minor style concern exists around multi-slash inputs being accepted, but it doesn't affect existing functionality.
• src/codereviewbuddy/gh.py — the parse_repo function's split("/", 1) behavior with multi-slash inputs could be tightened.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Tool function called with repo param"] --> B{"repo provided?"}
    B -- Yes --> C["gh.parse_repo(repo)"]
    B -- No --> D["gh.get_repo_info(cwd)"]
    C --> E{"'/' in repo?"}
    E -- No --> F["Raise GhError"]
    E -- Yes --> G["split('/', 1)"]
    G --> H{"owner and repo_name non-empty?"}
    H -- No --> F
    H -- Yes --> I["Return (owner, repo_name)"]
    D --> I
    I --> J["Proceed with GitHub API calls"]

_{Last reviewed commit: 6c2862b}