• build: copier update from template 0.29.2 #179
• fix: replace fastmcp update_config_file with encoding-safe implementation #178 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Greptile Summary

Replaces fastmcp's update_config_file() with an in-house JSON config merge in _write_config_file(). The fastmcp function omitted explicit encoding= on file I/O, triggering EncodingWarning errors in CI under PYTHONWARNDEFAULTENCODING=1. The new implementation reads existing config (if present), merges in the server entry via setdefault + assignment, and writes back with encoding="utf-8" throughout.

• Removed update_config_file import from fastmcp.mcp_config; only StdioMCPServer is still used
• New implementation correctly handles missing files, empty files, and preserves existing config entries
• Tests updated to use filesystem-based error triggers instead of mocking the removed function
• Output format now uses indent=2 pretty-printing, which is a minor improvement over the previous behavior

Confidence Score: 5/5

• This PR is safe to merge — it's a straightforward replacement of an upstream utility with an equivalent encoding-safe implementation.
• The change is small and well-scoped: a single function body rewritten with the same semantics, well-documented rationale, and tests updated to match. All edge cases (missing file, empty file, existing entries, write errors) are covered by existing tests.
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["_write_config_file(config_path, server_config)"] --> B{config_path exists?}
    B -- Yes --> C["Read file with encoding='utf-8'"]
    C --> D{Content non-empty?}
    D -- Yes --> E["json.loads(raw)"]
    D -- No --> F["config = {}"]
    B -- No --> F
    E --> G["config.setdefault('mcpServers', {})"]
    F --> G
    G --> H["config['mcpServers'][SERVER_NAME] = server_config.model_dump()"]
    H --> I["write_text(json.dumps(config), encoding='utf-8')"]
    I --> J["return True ✅"]
    E -- JSONDecodeError --> K["except Exception → return False ❌"]
    I -- OSError --> K

_{Last reviewed commit: 7323bab}

Merge activity

• Feb 18, 9:47 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 18, 9:47 AM UTC: @ichoosetoaccept merged this pull request with Graphite.