• fix: prevent wrong-cwd auto-detection when workspace not detected #175 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Greptile Summary

Fixed a bug where the server could auto-detect the wrong repository when workspace detection fails. The PR introduces a new _check_auto_detect_prerequisites() function that validates workspace detection succeeded before allowing auto-detection of repository and PR number parameters.

Key Changes:

• Added _WORKSPACE_HELP constant with clear error message guidance
• Enhanced _get_workspace_cwd() logging (debug → info for successful detection, improved warning messages)
• Created _check_auto_detect_prerequisites() to fail fast with helpful errors when workspace isn't detected and parameters are missing
• Integrated the prerequisite check into all 9 MCP tool endpoints before auto-detection occurs
• Added comprehensive test coverage with 6 new test cases

Impact:
Prevents confusing errors like "no pull requests found for branch main" when the server's process cwd happens to be a different git repo. Users now get clear guidance to explicitly pass repo and pr_number parameters when workspace detection fails.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The implementation is defensive, well-tested, and addresses a real UX issue. The new prerequisite check only raises errors in scenarios where auto-detection would have failed anyway (workspace not detected + missing parameters), making the failure mode clearer and more actionable. All 9 tool endpoints correctly call the check before auto-detection, and the comprehensive test suite validates all edge cases including partial parameter scenarios.
• No files require special attention

Important Files Changed

Flowchart

flowchart TD
    A[MCP Tool Called] --> B[get_workspace_cwd]
    B --> C{MCP Roots Available?}
    C -->|Yes| D[Return MCP Root Path]
    C -->|No| E{CRB_WORKSPACE Set?}
    E -->|Yes| F[Return Env Var Path]
    E -->|No| G[Return None + Warning]
    
    D --> H[check_auto_detect_prerequisites]
    F --> H
    G --> H
    
    H --> I{cwd Detected?}
    I -->|Yes| J[Auto-detection Safe]
    I -->|No| K{All Params Explicit?}
    K -->|Yes| J
    K -->|No| L[Raise GhError with Help]
    
    J --> M[Proceed with Auto-detection]
    M --> N[Execute Tool Logic]

_{Last reviewed commit: 0c72cf9}