Skip to content

test: add GraphQL error test for PRR dismiss flow#173

Merged
ichoosetoaccept merged 1 commit intomainfrom
02-17-test-add-graphql-error-test-for-prr-dismiss-flow
Feb 17, 2026
Merged

test: add GraphQL error test for PRR dismiss flow#173
ichoosetoaccept merged 1 commit intomainfrom
02-17-test-add-graphql-error-test-for-prr-dismiss-flow

Conversation

@ichoosetoaccept
Copy link
Member

@ichoosetoaccept ichoosetoaccept commented Feb 17, 2026

Add a test verifying that GraphQL errors during the dismissPullRequestReview mutation (PRR_ dismiss flow) correctly raise GhError. Mirrors the existing test_inline_thread_graphql_error_raises pattern.

Suggested by Greptile during review of PR #169.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps
Copy link

greptile-apps bot commented Feb 17, 2026

Greptile Summary

Adds test coverage for GraphQL error handling in the PRR dismiss flow. The new test verifies that when the GitHub GraphQL API returns an error while dismissing a PR-level review (PRR_ ID), the resolve_comment function correctly raises a GhError with "GraphQL error" in the message.

  • Added test_resolve_prr_graphql_error_raises to validate error handling for PRR dismissal
  • Test properly mocks the GraphQL response to return an errors array
  • Ensures the error propagates correctly through _dismiss_pr_review_check_graphql_errors

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The PR adds a single, well-structured test case that follows existing test patterns. The test correctly validates GraphQL error handling for the PRR dismiss flow, matching the implementation logic in the codebase. No production code changes, no potential side effects.
  • No files require special attention

Important Files Changed

Filename Overview
tests/test_comments.py Added new test for GraphQL error handling when dismissing PR reviews

Last reviewed commit: 7373ead

@ichoosetoaccept ichoosetoaccept merged commit 9da5b9a into main Feb 17, 2026
11 checks passed
@ichoosetoaccept ichoosetoaccept deleted the 02-17-test-add-graphql-error-test-for-prr-dismiss-flow branch February 17, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant