fix: apply _check_graphql_errors to query paths#168
Merged
ichoosetoaccept merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
Member
Author
This was referenced Feb 17, 2026
Greptile SummaryAdded missing GraphQL error checks to
Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[GraphQL Query] --> B{Response Received}
B --> C[_check_graphql_errors]
C --> D{Errors Field Present?}
D -->|Yes| E[Raise GhError with context]
D -->|No| F[Extract data from response]
F --> G[Process & return data]
style E fill:#ff6b6b
style G fill:#51cf66
style C fill:#ffd43b
Last reviewed commit: a877d2f |
95cfa5a to
a877d2f
Compare
Member
Author
|
@greptileai review |
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Apply
_check_graphql_errorsto the two GraphQL query paths that were missing error checks:_fetch_raw_threadsand_fetch_thread_detail.Previously, these functions silently swallowed GraphQL-level errors (e.g. auth failures, rate limits) because they only checked for data in the response without validating the
errorsfield. Now both paths raiseGhErrorwith a descriptive message.Changes
_fetch_raw_threads: added_check_graphql_errorsafter the paginated GraphQL call_fetch_thread_detail: added_check_graphql_errorsafter the thread detail queryFixes #145