Fix build error for GCC 14#117
Merged
john-preston merged 1 commit intodesktop-app:masterfrom Nov 27, 2024
Merged
Conversation
Contributor
|
That's a wrong fix. The right fix is #116. The person has closed the PR, sadly. |
FliegendeWurst
force-pushed
the
patch-1
branch
from
2b869b7 to
2f9621e
Compare
Contributor
Author
|
I have amended my commit based on what I could gather in the linked PR |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file uses QQuickWidget unconditionally, so we must always include the header. GCC 14 by default rejects undefined references to classes.