Skip to content

Add GitHub Actions #9680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafeca merged 72 commits into from
Aug 11, 2020
Merged

Add GitHub Actions #9680

rafeca merged 72 commits into from
Aug 11, 2020

Conversation

@outofambit
Copy link
Contributor

@outofambit outofambit commented Apr 30, 2020

[...]

@outofambit outofambit changed the title [WIP] gh actions smoke test [WIP] gh actions win32 smoke test Apr 30, 2020
@shiftkey
Copy link
Member

shiftkey commented May 1, 2020

@outofambit I noticed a similar issue on Azure Pipelines recently, and added shiftkey@42f219c to workaround the issue

outofambit
outofambit commented May 4, 2020
View reviewed changes
@outofambit outofambit force-pushed the spike/actions-win32 branch from ae49445 to 79a5dc4 Compare May 5, 2020 17:49
@outofambit outofambit mentioned this pull request May 5, 2020
Merged
amir4toshiba
amir4toshiba previously approved these changes Jun 6, 2020
View reviewed changes
niik added 8 commits July 9, 2020 14:03
@niik
Merge branch 'development' into spike/actions-win32
4f88090
@niik
Set CI env var for all steps
c426945 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
@niik
Get SHA on GitHub Actions
134beec
@niik
Get whether we're on a fork in an action
cc9e4b2 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
@niik
We can build on Windows on GH actions as well
4d10b0d
@niik
This is already set by default
0e52cee 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
@niik
GitHub Actions can build on darwin as well
c308631
@niik
Skip this for now
50bba8d 
We don't use listWorkTrees and it's causing problems on GitHub actions
@niik niik dismissed a stale review via 622428b August 5, 2020 15:53
@niik niik mentioned this pull request Aug 7, 2020
Merged
rafeca
rafeca previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafeca
rafeca approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@rafeca rafeca merged commit 56dc6a5 into development Aug 11, 2020
@rafeca rafeca deleted the spike/actions-win32 branch August 11, 2020 16:35
@outofambit
Copy link
Contributor Author

outofambit commented Aug 11, 2020 •
edited
Loading

OH EM GEE

@rafeca @niik

@rafeca rafeca mentioned this pull request Aug 13, 2020
Merged
@rafeca rafeca restored the spike/actions-win32 branch August 13, 2020 08:56
@rafeca rafeca deleted the spike/actions-win32 branch August 13, 2020 08:57
@niik niik mentioned this pull request Aug 18, 2020
Merged
4 tasks
@rafeca rafeca mentioned this pull request Aug 21, 2020
Closed
@shiftkey shiftkey mentioned this pull request Aug 24, 2020
Merged
2 tasks
@say25 say25 mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niik niik niik approved these changes

+2 more reviewers

@rafeca rafeca rafeca approved these changes

@amir4toshiba amir4toshiba amir4toshiba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@outofambit @shiftkey @rafeca @niik @rjduncan564 @amir4toshiba