Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list scrollable when zoomed #16425

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Conversation

tidy-dev
Copy link
Contributor

xref https://github.com/github/accessibility-audits/issues/3290
xref https://github.com/github/accessibility-audits/issues/3289

Description

When the app is zoomed to 200%,

  1. The undo button no longer overlaps the commit button.
  2. The changes list now has a minimum height of 100px so a few list items are always visible.
  3. The whole changes list panel starts scrolling when they all will no longer fit in the vertical height.
  4. The description text area collapses to 20px height instead of 80px when zoomed in to reduce panel scrolling when zoomed.
  5. Once changes list was visible, the file names were no longer visible due to some clipping logic based on an inaccurate available width.
    • That available width was the sidebar width was being clamped between a min and max. The max being window.innerWidth minus a fixed const of 460px that represents the toolbar buttons width. When the app is zoomed the window.innerWidth to be not much more than 460px. Thus, even tho the sidebar width value is never goes below 220 (the minimum), the max is around 50px and the clamped value was being used which would be 50px.

Screenshots

CleanShot.2023-03-30.at.21.30.30.mp4

Release notes

Notes: [Fixed] Clipping and overlapping of the changes list fixed at 200% zoom.

@tidy-dev tidy-dev requested a review from niik April 5, 2023 14:06
@tidy-dev tidy-dev merged commit 6705f5b into development Apr 6, 2023
@tidy-dev tidy-dev deleted the change-list-scrollable-zoomed branch April 6, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants