Switch to using the dart version of sass instead of node-sass #11019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
approved these changes
Nov 12, 2020
Contributor
dennisameling
left a comment
dennisameling
left a comment
There was a problem hiding this comment.
Thanks! Can confirm this works on arm64 Windows 🚀
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseedes #10949
Description
In #10949 @dennisameling graciously updated our version of node-sass to v5 which is required to move us forward with the Windows/arm64 work. This PR takes a slightly different approach by switching the engine out entirely in favor of the "pure JS" version of the sass compiler. In theory this could affect build performance negatively but if anything it appears to be faster from the few tests I've done though that could be related to the upgraded sass-loader as well.
See #10949 (comment)
This will rid us of one more native module which will be helpful with both the Windows ARM64 and the upcoming macOS ARM64 builds.