Skip to content

Conversation

@dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Oct 31, 2020

Closes #N/A

Description

Screenshots

N/A

Release notes

Notes:

  • Update node-sass to v5.0.0

@niik
Copy link
Member

niik commented Nov 2, 2020

Hey @dennisameling, thanks for opening this! I'd be happy to merge this as-is but I'm wondering if we should just switch out node-sass in favor of sass and avoid the native compilation step altogether. It seems that's what webpack is recommending these days

ℹ️ We recommend using Dart Sass.

I believe we'd need to swap node-sass for sass in addition to bumping sass-loader to the latest version.

What do you think?

@dennisameling
Copy link
Contributor Author

Moving to sass makes sense I think, but unfortunately I don't have the bandwidth currently to look into a possible migration path. I'm very close to having a working GH Desktop build process on native Windows ARM64, which will allow me to verify if there are any failing tests on this platform 🚀

@niik
Copy link
Member

niik commented Nov 2, 2020

Moving to sass makes sense I think, but unfortunately I don't have the bandwidth currently to look into a possible migration path

That's not a problem. Let me see if I can find some time to do it in the next couple of days (I believe I might have done it already on a local branch somewhere) and if not then we can just merge this. Are you able to work around this problem currently or are you blocked until one of the two solutions lands on development?

@dennisameling
Copy link
Contributor Author

I'm not blocked currently as I updated node-sass to v5 in my local branch. Thanks!!

@niik
Copy link
Member

niik commented Nov 12, 2020

Gonna close this in favor of #11019 which incorporates this branch

@niik niik closed this Nov 12, 2020
@dennisameling dennisameling deleted the node-sass-v5 branch November 12, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants